Skip to content

📦️ Archive packaging-related artifacts again#356

Merged
denialhaag merged 2 commits into
mainfrom
fix-cd
Apr 8, 2026
Merged

📦️ Archive packaging-related artifacts again#356
denialhaag merged 2 commits into
mainfrom
fix-cd

Conversation

@denialhaag
Copy link
Copy Markdown
Member

Description

This PR reverts some of the changes made in #332 to reduce CD complications. Furthermore, this PR prepares the immediate release of v1.18.1.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@denialhaag denialhaag self-assigned this Apr 8, 2026
@denialhaag denialhaag added the fix Fix for something that is not working label Apr 8, 2026
@denialhaag denialhaag requested a review from burgholzer April 8, 2026 21:23
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 13dc69fe-7a5a-41c4-89c6-f3cacf4ec0f6

📥 Commits

Reviewing files that changed from the base of the PR and between 62c72cf and 9cf95df.

📒 Files selected for processing (1)
  • CHANGELOG.md

📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated GitHub Actions workflows to re-enable artifact archiving for packaging build artifacts (source distributions and wheels).
  • Documentation

    • Added release notes for version 1.18.1 documenting changes to artifact upload behavior.
    • Added upgrade documentation for versions 1.18.1 and 1.17.15 with guidance on GitHub Actions artifact handling configuration.

Walkthrough

This PR removes the archive: false parameter from GitHub Actions artifact upload steps in two Python packaging workflows and updates documentation to reflect the reversion of archiving behavior for packaging artifacts to the default state.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/reusable-python-packaging-sdist.yml, .github/workflows/reusable-python-packaging-wheel-build.yml
Removed archive: false input from actions/upload-artifact steps, reverting to default archiving behavior for dist artifacts (.tar.gz and .whl).
Release Documentation
CHANGELOG.md, UPGRADING.md
Added version 1.18.1 changelog entry and upgrade notes documenting the reversion of artifact archiving behavior. Included version comparison links and upgrade guidance for versions 1.18.1 and 1.17.15.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #332: Directly related—this PR removes the archive: false parameter that was added in a prior change, reverting the artifact upload configuration to its original state.

Suggested labels

continuous integration

Suggested reviewers

  • burgholzer

Poem

🐰 A hop back in time, so swift and so fine,
No more archive: false—let artifacts align!
The workflows now breathe with their defaults restored,
Packaging peace, by our bunny adored! ✨📦

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: reverting the archive:false setting to enable artifact archiving again for packaging workflows.
Description check ✅ Passed The description explains the purpose (reverting #332 changes and preparing v1.18.1 release), completes required checklist items, and documents migration instructions were added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-cd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
We just need to be careful to not forget to adjust this in MQT Bench once released, because there, the pattern is currently wrong then.

@denialhaag denialhaag merged commit b59d15a into main Apr 8, 2026
6 checks passed
@denialhaag denialhaag deleted the fix-cd branch April 8, 2026 23:02
@denialhaag
Copy link
Copy Markdown
Member Author

We just need to be careful to not forget to adjust this in MQT Bench once released, because there, the pattern is currently wrong then.

I have reverted munich-quantum-toolkit/bench#870 in munich-quantum-toolkit/bench#880. 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix for something that is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants