-
Notifications
You must be signed in to change notification settings - Fork 222
update go mod #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/supernova-async-exec
Are you sure you want to change the base?
update go mod #7690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the mx-chain-core-go dependency reference to a newer pseudo-version, keeping this repository aligned with upstream core changes.
Changes:
- Bump
github.com/multiversx/mx-chain-core-gotov1.4.2-0.20260210103132-fc549fe6a7f4ingo.mod - Update corresponding checksums in
go.sum
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the required mx-chain-core-go version to a newer pseudo-version. |
| go.sum | Refreshes module checksums to match the updated dependency version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
go.mod
Outdated
| github.com/mitchellh/mapstructure v1.5.0 | ||
| github.com/multiversx/mx-chain-communication-go v1.3.0 | ||
| github.com/multiversx/mx-chain-core-go v1.4.2-0.20260130090903-7407465d70c6 | ||
| github.com/multiversx/mx-chain-core-go v1.4.2-0.20260210103132-fc549fe6a7f4 |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is still the unfilled template (no reasoning/proposed changes/testing procedure). Since this change bumps mx-chain-core-go to a new pseudo-version, please document what drove the update and what tests/commands were run (e.g., make test) so reviewers can assess impact.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/supernova-async-exec #7690 +/- ##
==========================================================
Coverage 77.51% 77.51%
==========================================================
Files 882 882
Lines 122753 122754 +1
==========================================================
+ Hits 95148 95157 +9
+ Misses 21261 21257 -4
+ Partials 6344 6340 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ssd04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to be backwards compatible. StateAccesses in outport driver is not set anymore, it has to be set until supernova round is activated.
…s-incompatibility-fix
…s-incompatibility-fix
…s-incompatibility-fix
| stateAccesses := odp.getStateAccessForRootHash(rootHash) | ||
| stateAccessesForBlock[hex.EncodeToString(headerHash)] = stateAccesses | ||
| return stateAccessesForBlock | ||
| return nil, stateAccesses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think would help to still keep returning stateAccessesForBlock with one element in map before supernova, not nil, it would be easier to handle in integrators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?