refactor(fan-flames): eliminate dual isolation — orchestrator-managed jj workspaces#54
Merged
Merged
Conversation
… jj workspaces Remove isolation: "worktree" from fan-flames dispatch. The orchestrator now creates jj workspaces directly and agents cd into them, eliminating the nondeterministic dual isolation (Claude Code worktree + jj workspace hook) that caused mixed Pattern A/B/C within single waves. Changes: - FAN OUT: orchestrator creates workspaces via jj workspace add, agents dispatched without isolation flag, cd + verify as first action - COLLECT: integrity check promoted from edge-case handler to primary gate - REVIEW: wave-end sweep for orphaned/leaked workspaces - FAN IN: Pattern A/C retained as safety net with annotations - Workspace lifecycle: orchestrator owns full create/destroy, hooks uninvolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isolation: "worktree"from fan-flames dispatch — the orchestrator now creates jj workspaces directly viajj workspace addand agentscdinto them, eliminating the nondeterministic dual isolation (Claude Code worktree + jj workspace hook) that caused mixed Pattern A/B/C within single wavescdfailures before review wastes cycles, replacing the former Pattern C edge-case handler/tmpdirectory leaksTest plan
jj squashno longer returns "Nothing changed" for any taskWorktreeRemoveor stale hook references remain in the skill🤖 Generated with Claude Code