fix(workspace-jj): create workspaces outside repo to prevent auto-snapshot leak#50
Merged
Conversation
…pshot leak Root cause: .claude/workspaces/ was inside the repo root. jj's default workspace auto-snapshots ALL files under the repo, including workspace directories. When a Wave 2 agent edited files inside .claude/workspaces/agent-XXXX/, jj attributed the changes to the default workspace's @ instead of the agent workspace's @. Fix: Create workspaces in /tmp/jj-workspaces/<project>/<name>/ instead. This keeps workspace directories outside jj's auto-snapshot scope. Also includes v2 calibration: - Tiered spec review (trivial tasks verified inline, skip reviewer agent) - Parallelism threshold warning (<40% parallelizable suggests single-agent) - Workspace integrity check (Pattern C detection) - JJ_EDITOR=true for squash commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/workspaces/. jj's default workspace auto-snapshots all files under the repo root, so when a Wave 2 agent edited files inside a workspace directory, jj attributed the changes to the default workspace's@instead of the agent's workspace./tmp/jj-workspaces/<project>/<name>/instead — outside jj's auto-snapshot scope.jj-workspace-create.shBug report
Test plan
jj-workspace-create.shuses/tmp/jj-workspaces/path in both plugins.claude/workspaces/remain in live code (historical docs ok)/fan-flamesUAT with multi-wave plan to confirm isolation holds🤖 Generated with Claude Code