[pigment-core] React implementation for the new Pigment CSS API #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brijeshb42
commented
Jan 14, 2025
brijeshb42
commented
- I have followed (at least) the PR section of the contributing guide.
brijeshb42
force-pushed
the
v1/react-package
branch
2 times, most recently
from
493fe2c to
534e9c4
Compare
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
from
534e9c4 to
eb5c3c5
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
3 times, most recently
from
b6cb7ee to
9d6424d
Compare
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
from
9d6424d to
0c8a1c0
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
6 times, most recently
from
6e259a9 to
a0d632c
Compare
brijeshb42
force-pushed
the
v1/react-package
branch
from
77a085d to
155b9ef
Compare
brijeshb42
force-pushed
the
v1/react-package
branch
5 times, most recently
from
f55bf27 to
7eecf99
Compare
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
from
7eecf99 to
2f1a12d
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
changed the title
brijeshb42
force-pushed
the
v1/react-package
branch
from
2f1a12d to
b900094
Compare
brijeshb42
commented
Feb 27, 2025
| ? T | ||
| : never; | ||
|
|
||
| function handleTemplateElementOrSimilar( |
Contributor
Author
There was a problem hiding this comment.
This is the test for the change in implementation.
brijeshb42
commented
Feb 27, 2025
Contributor
Author
There was a problem hiding this comment.
I'll add the implementation for sx in a separate PR. At the current stage, the new package doesn't support sx prop.
1 task
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
v1/react-package
branch
from
60368c1 to
5a8e8c8
Compare
github-actions
bot
removed
the
PR: out-of-date
dsonet
reviewed
Mar 21, 2025
| @@ -0,0 +1,152 @@ | |||
| { | |||
| "name": "@pigment-css/react-new", | |||
There was a problem hiding this comment.
Hey there. Thanks for your work. A question about this package name, are we going to remove the -new before it is released?
Contributor
Author
There was a problem hiding this comment.
Yes. Its temporary right now. Before release, this'll become @pigment-css/react and old one will be renamed.
added 11 commits
March 21, 2025 15:25
brijeshb42
force-pushed
the
v1/react-package
branch
from
5a8e8c8 to
5e57953
Compare
Janpot
reviewed
Mar 24, 2025
| const { themeArgs = {}, pigmentFeatures: { useLayer = true } = {} } = | ||
| processor.options as TransformedInternalConfig; | ||
| // @ts-ignore @TODO - Fix this. No idea how to initialize a Tagged String array. | ||
| const templateStrs: string[] = []; |
Member
There was a problem hiding this comment.
const x: TemplateStringsArray = Object.assign([], { raw: [] })
Janpot
reviewed
Mar 24, 2025
|
|
||
| isMaybeTransformedTemplateLiteral(values: ValueCache): boolean { | ||
| const [, firstArg, ...restArgs] = this.callParam; | ||
| if (!('kind' in firstArg) || firstArg.kind === ValueType.CONST) { |
Member
There was a problem hiding this comment.
I don't think I've used the in operator in over a decade 😄
It's purely stylistic in this instance, .hasOwnProperty feels more predictable to me.
Member
There was a problem hiding this comment.
I think in makes TS happy too, not sure about .hasOwnProperty.
Contributor
Author
There was a problem hiding this comment.
Correct. in narrows the types to the expected ones.
Janpot
reviewed
Mar 24, 2025
| @@ -0,0 +1,29 @@ | |||
| # Pigment CSS | |||
Member
There was a problem hiding this comment.
Content like this would be useful on the docs. Like a landing page with a bit more information.
Contributor
Author
siriwatknp
reviewed
Mar 28, 2025
|
|
||
| const { result: baseObj, variables } = processStyle(style, { getVariableName }); | ||
| const cssText = serializeStyles([baseObj as any]).styles; | ||
| const { styles: cssText } = serializeStyles([baseObj as any]); |
Member
There was a problem hiding this comment.
Casting type to serializeStyles's input argument would be better than any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.