Skip to content

chore: ⬆️ Update CrispStrobe/CrispASR to a38cb89f7b9a743db2e8e50869fa646f91dc7f08#10873

Merged
mudler merged 2 commits into
mudler:masterfrom
ci-forks:update/CRISPASR_VERSION
Jul 17, 2026
Merged

chore: ⬆️ Update CrispStrobe/CrispASR to a38cb89f7b9a743db2e8e50869fa646f91dc7f08#10873
mudler merged 2 commits into
mudler:masterfrom
ci-forks:update/CRISPASR_VERSION

Conversation

@localai-bot

Copy link
Copy Markdown
Collaborator

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@localai-bot
localai-bot force-pushed the update/CRISPASR_VERSION branch from 5fedbea to d62329e Compare July 16, 2026 21:01
CrispASR a38cb89 adds a crispasr_c2pa_native static library whose sources
live in the new third_party/c2pa-audio git submodule, located via
CMAKE_SOURCE_DIR in src/CMakeLists.txt. That variable assumes CrispASR is
the top-level CMake project; LocalAI embeds it via add_subdirectory, so
the path resolved to backend/go/crispasr/third_party/c2pa-audio and every
build variant failed at CMake generate with 'Cannot find source file:
c2pa_native.cpp'.

Extend the existing talk-llama sed workaround to also rewrite the
c2pa-audio reference to PROJECT_SOURCE_DIR, which is correct both
standalone and as a subproject. The submodule itself is already checked
out by the recursive submodule init. Verified locally: the exact CI error
reproduces with CMAKE_SOURCE_DIR, and with the rewrite CMake configure,
crispasr_c2pa_native, and crispasr-lib all build cleanly on a CPU-only
fallback configuration.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude Code:claude-opus-4-8
@localai-bot

Copy link
Copy Markdown
Collaborator Author

All backend-build variants were failing at CMake generate with:

CMake Error at sources/CrispASR/src/CMakeLists.txt:244 (add_library):
  Cannot find source file:
    .../backend/go/crispasr/third_party/c2pa-audio/src/c2pa_native.cpp

Root cause: upstream a38cb89 adds a new crispasr_c2pa_native static library (pure-C++ C2PA WAV signer) whose sources live in the new third_party/c2pa-audio git submodule, located via ${CMAKE_SOURCE_DIR} in src/CMakeLists.txt. That works standalone, but LocalAI embeds CrispASR via add_subdirectory, so CMAKE_SOURCE_DIR resolves to backend/go/crispasr instead of the CrispASR checkout and the source file is not found. Same class of issue we already patch for the talk-llama path.

Fix (pushed as b459ebb): extend the existing sed workaround in backend/go/crispasr/Makefile to also rewrite the c2pa-audio reference to ${PROJECT_SOURCE_DIR}. The submodule itself was already covered by the recursive submodule init. Verified locally on a CPU-only fallback configuration: the exact CI error reproduces with CMAKE_SOURCE_DIR, and with the rewrite CMake configure plus crispasr_c2pa_native and crispasr-lib build cleanly. The C-ABI changes in this bump are purely additive, so the Go shim needs no changes.

Long term it would be nice to fix this upstream by using PROJECT_SOURCE_DIR in src/CMakeLists.txt (both the talk-llama and c2pa-audio references), then the sed can go away.

@mudler
mudler merged commit cbf232e into mudler:master Jul 17, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants