This repository was archived by the owner on Aug 31, 2025. It is now read-only.
Resolve the actual data path for windows distrubutions - #2292
Open
tonybaloney wants to merge 13 commits into
Open
Resolve the actual data path for windows distrubutions#2292tonybaloney wants to merge 13 commits into
tonybaloney wants to merge 13 commits into
Conversation
tonybaloney
marked this pull request as ready for review
July 16, 2022 13:47
tonybaloney
marked this pull request as draft
July 16, 2022 14:11
tonybaloney
marked this pull request as ready for review
July 16, 2022 15:05
Collaborator
|
@tonybaloney would you mind running a |
Contributor
Author
|
@tjguk done (the failing test is failing on all PRs) |
Member
Yes, the linux sementation fault used to be a lot more sporadic, now it seems to fail once in every CI run. We need to investigate further, but we haven't been able to replicate. I've restarted the failing job, should pass the second time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if the host Python is from the Windows store then DATA_DIR will be different with subproceses. This causes a crash creating virtual environments.
See mu-editor/crash-reports#228
Fixes #2293