WIP: Upgrade PyQt5 to PyQt6. by carlosperate · Pull Request #2279 · mu-editor/mu

carlosperate · 2022-06-29T12:42:56Z

This is a work in progress, so the tests are still failing, but Mu is launching.

Some useful links:

One current issue:

PyQt6 port might not work on Raspberry Pi #2278

ntoll · 2022-06-29T12:52:57Z

oooOOOOOoooooh. This is very exciting. Really great work @carlosperate 🎉 Something to hit with a big stick during EuroPython sprints. 😁 🇪🇺 🐍

lgtm-com · 2022-06-29T12:58:12Z

This pull request introduces 1 alert when merging 794e7e7 into 5be0c29 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2022-07-17T11:21:20Z

This pull request introduces 1 alert when merging 87c3b5a into 9fe47ac - view on LGTM.com

new alerts:

1 for Unused import

And update the CI test configuration.

…ode.

cclauss

Nice to see!!! 57 checks on every pull request seems like a lot of complexity to manage and a lot of CPU to burn. Of course, we want all these platforms to work in the long run but are there some platforms that are easier so we can get mu on PyQt6 working end-to-end on a few. Awesome effort!

cclauss · 2023-12-09T01:12:47Z

-            python-version: '3.5'
-          - os: ubuntu-latest
-            python-version: '3.6'
+        python-version: ['3.8', '3.9', '3.10', '3.11']


Suggested change

python-version: ['3.8', '3.9', '3.10', '3.11']

python-version: ['3.8', '3.9', '3.10', '3.11', ‘3.12’]

cclauss · 2023-12-09T01:13:21Z

        timeout-minutes: 5

  test-arm:
+    # Missing Qt6 versions of: python3-pyqt5.qsci python3-pyqt5.qtchart


Has this situation improved?

cclauss · 2023-12-09T01:17:47Z

+    if: false
    runs-on: ubuntu-latest
-    name: Test Py 3.7 - arm-debian-buster
+    name: Test Py 3.10 - arm-debian-bookworm


Is bookworm’s default Python 3.10 or 3.11?

cclauss · 2023-12-09T01:18:08Z

-    name: Test Py 3.7 - arm-debian-buster
+    name: Test Py 3.10 - arm-debian-bookworm
    steps:
      - uses: actions/checkout@v3


Suggested change

- uses: actions/checkout@v3

- uses: actions/checkout@v4

cclauss · 2023-12-09T01:20:11Z

              python -m pip config list &&
              python -m pip list &&
-              python -m pip install .[dev] &&
+              python -m pip install cryptography pyzmq cffi --python-version 3.9 --only-binary \":all:\" --no-deps --target venv/lib/python3.10/site-packages/ &&


This line creates a Py3.9 binary and puts into the Py3.10 site packages?

cclauss · 2023-12-09T01:25:32Z

    # which are needed for the main editor to function.
    #
-    "PyQt5==5.13.2"
+    "PyQt6==6.3.1"


Suggested change

"PyQt6==6.3.1"

"PyQt6==6.6.1"

cclauss · 2023-12-09T01:25:52Z

+    "PyQt6==6.3.1"
    + ';"arm" not in platform_machine and "aarch" not in platform_machine',
-    "QScintilla==2.11.3"
+    "PyQt6-QScintilla==2.13.3"


Suggested change

"PyQt6-QScintilla==2.13.3"

"PyQt6-QScintilla==2.14.1"

cclauss · 2023-12-09T01:27:10Z

+    "PyQt6-QScintilla==2.13.3"
    + ';"arm" not in platform_machine and "aarch" not in platform_machine',
-    "PyQtChart==5.13.1"
+    "PyQt6-Charts==6.3.1"


Suggested change

"PyQt6-Charts==6.3.1"

"PyQt6-Charts==6.6.0"

cclauss · 2023-12-09T01:27:26Z

        "mu.wheels",
    ],
-    python_requires=">=3.5,<3.9",
+    python_requires=">=3.7,<3.12",


Suggested change

python_requires=">=3.7,<3.12",

python_requires=">=3.8,<3.13",

cclauss · 2023-12-09T01:28:25Z

        "Programming Language :: Python :: 3.8",
+        "Programming Language :: Python :: 3.9",
+        "Programming Language :: Python :: 3.10",
+        "Programming Language :: Python :: 3.11",


Suggested change

"Programming Language :: Python :: 3.11",

"Programming Language :: Python :: 3.11",

"Programming Language :: Python :: 3.12",

carlosperate force-pushed the pyqt6 branch 2 times, most recently from 858f18d to 87c3b5a Compare July 17, 2022 11:06

carlosperate force-pushed the pyqt6 branch 2 times, most recently from f9f8801 to ce72b95 Compare July 17, 2022 14:32

This was referenced Jul 17, 2022

Cannot run mu-editor developer version on macOS #2303

Closed

Mu v1.3.0 will need pip>=20.3 in Linux to install manylinux_2_28 wheels #2305

Open

carlosperate force-pushed the pyqt6 branch 21 times, most recently from a338a3c to e4bbb38 Compare July 18, 2022 17:32

carlosperate force-pushed the pyqt6 branch 2 times, most recently from 9efdd96 to dc50e2f Compare July 18, 2022 17:46

carlosperate added 2 commits July 18, 2022 20:22

Upgrade PyQt5 to PyQt6.

380cfe2

Remove support for Python 3.5 & 3.6, add support for 3.9-3.11.

89163fa

And update the CI test configuration.

carlosperate force-pushed the pyqt6 branch from dc50e2f to 89163fa Compare July 18, 2022 19:23

tmontes added 4 commits July 19, 2023 15:55

Merge branch 'master' into pyqt6

d2dc2ba

Merge branch 'master' into pyqt6

2752208

Merge branch 'master' into pyqt6

ee1de7a

Fix bad merge conflict resolution WRT single instance running check c…

97ffbb2

…ode.

cclauss reviewed Dec 9, 2023

View reviewed changes

	python-version: ['3.8', '3.9', '3.10', '3.11']
	python-version: ['3.8', '3.9', '3.10', '3.11', ‘3.12’]

	python_requires=">=3.7,<3.12",
	python_requires=">=3.8,<3.13",

	"Programming Language :: Python :: 3.11",
	"Programming Language :: Python :: 3.11",
	"Programming Language :: Python :: 3.12",

Uh oh!

Conversation

carlosperate commented Jun 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntoll commented Jun 29, 2022

Uh oh!

lgtm-com Bot commented Jun 29, 2022

Uh oh!

lgtm-com Bot commented Jul 17, 2022

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss Dec 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

carlosperate commented Jun 29, 2022 •

edited

Loading

cclauss Dec 9, 2023 •

edited

Loading