Automatically join channels when msgs are received / Add custom cookies param / Handle multiple join/parts (rebased) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
just like #7, only rebased on current master. Tested by me, works good so far. |
|
Is this project dead? What's going on? How come it's taking so long to merge these PRs??? |
|
I have also tried this and it works like a charm. |
|
Merge merge merge! |
Author
|
@mtomwing would you be so kind to take a look again if you can merge this PR or give feedback which part you are not ok with? |
Author
|
https://github.com/bblancha/pickups is probably a better alternative, closing my PR unmerged to cleanup my "open pull request" view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is