[Update] Valet Key#538
Open
v-federicoar wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a dependency maintenance pass on the valet-key cloud design pattern sample, bumping two version references to their current stable releases. It also includes a trailing whitespace cleanup in the README. No functional or logic changes are made.
Changes:
- Bumps
Microsoft.Azure.Functions.WorkerNuGet package from 2.51.0 to 2.52.0 - Updates the Azure Storage Accounts Bicep API version from
2025-06-01to2026-04-01 - Removes trailing whitespace on one line in
README.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
valet-key/ValetKey.Web/ValetKey.Web.csproj |
Bumps Microsoft.Azure.Functions.Worker to 2.52.0 |
valet-key/README.md |
Trailing whitespace removal on line 9 (no content change) |
valet-key/bicep/main.bicep |
Updates Storage Accounts API version to 2026-04-01 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reviews the
valet-keysample to ensure it is current and secure. No code changes are made; the sample is already aligned with best practices for user-delegated SAS token generation.What was reviewed
GetUserDelegationKeyAsync()Security alert validation
A GitHub secret scanning alert flagged a hardcoded storage account key (
Password #2) in historical commits. This alert was validated as resolved:UserDelegationKey, not account keys.allowSharedKeyAccess: false, enforcing that only managed identity and user delegation can authenticate.44a16d7(update valuescontroller) andcc8e0d2(Update ValetKey to Track 2), dating from the legacy codebase refactor to isolated worker model.Validation