-
Couldn't load subscription status.
- Fork 322
Timestamp support #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp support #565
Conversation
| // Corner-cases around uint32 boundaries | ||
| for (v <- Seq( | ||
| Instant.ofEpochSecond(Instant.now().getEpochSecond, 123456789L), // uint32 nanoseq (out of int32 range) | ||
| Instant.ofEpochSecond(-1302749144L, 0), // 1928-09-19T21:14:16Z | ||
| Instant.ofEpochSecond(-747359729L, 0), // 1946-04-27T00:04:31Z | ||
| Instant.ofEpochSecond(4257387427L, 0) // 2104-11-29T07:37:07Z | ||
| )) { | ||
| check(v, _.packTimestamp(v), _.unpackTimestamp()) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test cases are for fixing uint32 conversion bugs in #431
|
@komamitsu I'll merge this and prepare 0.9.0 release. |
|
@xerial @komamitsu If |
Follow-up work of #431
This PR is based on the commits at #431 and the timestamp implementation of airframe-msgpack https://github.com/wvlet/airframe/tree/master/airframe-msgpack/src/main/scala/wvlet/airframe/msgpack/spi