-
Notifications
You must be signed in to change notification settings - Fork 88
pre-commit autoupdate #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining and improving the project's code quality and consistency by updating the pre-commit configuration. It brings several existing pre-commit hooks to their latest versions and introduces a new check to prevent issues with Windows-incompatible filenames, ensuring a more robust and compatible codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several pre-commit hooks to their latest versions and introduces the check-illegal-windows-names hook. Keeping dependencies updated is great practice, and the new hook will improve cross-platform compatibility by preventing filenames that are invalid on Windows.
I've noted one major version upgrade for pre-commit-hooks from v5 to v6. I've left a specific comment regarding this with some details on potential breaking changes you should be aware of.
| description: detect hardcoded secrets with gitleaks | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v5.0.0 | ||
| rev: v6.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates pre-commit-hooks from v5.0.0 to v6.0.0, which is a major version update. It's worth being aware of the breaking changes introduced in v6.0.0, as they could impact your development workflow.
Some notable changes include:
- Several hooks used in this configuration (
check-case-conflict,check-executables-have-shebangs,check-shebang-scripts-are-executable) now require Python 3.8 or newer to run. - The
autopep8-wrapperhook has been removed (it was not used in this project). - The underlying tools for
check-json,check-toml, andcheck-yamlhave been changed, which might lead to different behavior.
While pre-commit manages its own environments, it's good to be aware of these changes to prevent unexpected issues.
Add pre-commit hook
check-illegal-windows-names