Improve Docker container definition.#79
Merged
Merged
Conversation
This changes the container from blocking on start until it finds a root to creating it itself instead. This allows the service to be run out of the box with just a `docker run outpack_server`. In the past we were going to use a Git clone as the outpack root so it made sense to have more control over the creation of it, but we've gone down a different route now. Additionally it adds [tini][tini] as an entrypoint wrapper to make sure we have a well behaved PID 1. This avoids the issue of the container taking a long time to shutdown. [tini]: https://github.com/krallin/tini
plietar
force-pushed
the
improve-container
branch
from
aa8d378 to
d08d4d2
Compare
M-Kusumgar
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the container from blocking on start until it finds a root to creating it itself instead. This allows the service to be run out of the box with just a
docker run outpack_server.In the past we were going to use a Git clone as the outpack root so it made sense to have more control over the creation of it, but we've gone down a different route now.
Additionally it adds tini as an entrypoint wrapper to make sure we have a well behaved PID 1. This avoids the issue of the container taking a long time to shutdown.