include interpolate#321
Merged
Merged
Conversation
M-Kusumgar
commented
Jan 8, 2026
|
|
||
|
|
||
| compile_dll <- function(...) { | ||
| compile_dll_wrapper <- function(...) { |
Contributor
Author
There was a problem hiding this comment.
this was stupid, i spent like 2 hours+ on this bug, basically testthats local_mocked_bindings mocks a function, however because our function was called compile_dll and a function we wanted to mock was pkgbuild::compile_dll, it applied our mock to this function even though i specified .package = "pkgbuild" in the local_mocked_bindings
tbf cant be too mad at it XD they say its not good practice to mock third party functions but oh well, the fix was simple once i figured it out, just call it something else
EmmaLRussell
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this updates the bundle to one including interpolate from PR mrc-ide/dust-js#17, once that is merged into main, ill update the ref in update_js