Refactor libass build to use BuildShared and shared workflows #5

Copilot · 2026-02-02T03:58:22Z

Refactor the libass build project to rely on mpvkit/BuildShared and reuse BuildShared GitHub Actions workflows via uses:.

Build scripts
- Depend on BuildShared in Sources/BuildScripts/Package.swift.
- Replace local build infrastructure with BuildShared imports and shared option/runner usage.
- Add libass dependency flags in the BuildShared-based build class.
CI workflows
- Switch build/check_version workflows to mpvkit/BuildShared/.github/workflows/*.
- Add explicit permissions in wrapper workflows.

Example (build runner + shared options):

import BuildShared

let options = try ArgumentOptions.parse(CommandLine.arguments)
try BuildRunner.performCommand(options)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/mpvkit/BuildShared/contents/Sources/BuildShared
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
https://api.github.com/repos/mpvkit/BuildShared/tags
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
r.jina.ai
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: cxfksword <[email protected]>

cxfksword · 2026-02-02T07:46:16Z

Sources/BuildScripts/XCFrameworkBuild/base.swift

直接删除Base.swift

Copilot

Pull request overview

This pull request refactors the libass build project to use the shared mpvkit/BuildShared library instead of maintaining local build infrastructure. The refactoring consolidates build logic, updates workflows to use shared GitHub Actions, and migrates to BuildShared's types and utilities.

Changes:

Added BuildShared as a dependency and migrated to shared build infrastructure
Replaced ~1300 lines of local build code with type aliases and imports from BuildShared
Updated CI workflows to use shared reusable workflows from BuildShared repository

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Sources/BuildScripts/Package.swift	Added BuildShared dependency and updated target configuration
Sources/BuildScripts/XCFrameworkBuild/base.swift	Replaced entire build infrastructure with type aliases to BuildShared components
Sources/BuildScripts/XCFrameworkBuild/main.swift	Updated to use BuildShared types (BuildRunner, SharedBuildOptions) and added BuildLibrary conformance
.github/workflows/build.yml	Switched to shared BuildShared workflow with explicit permissions
.github/workflows/check_version.yml	Switched to shared BuildShared workflow with explicit permissions
.gitignore	Added Package.resolved to ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-02T07:50:22Z

.github/workflows/check_version.yml

+    permissions:
+      contents: write
+      pull-requests: write
+    uses: mpvkit/BuildShared/.github/workflows/check_version.yml@main


Using '@main' branch for the reusable workflow is not recommended for production as it can introduce breaking changes unexpectedly. Consider pinning to a specific version tag or commit SHA for stability and predictability. For example: uses: mpvkit/BuildShared/.github/workflows/[email protected].

Suggested change

uses: mpvkit/BuildShared/.github/workflows/check_version.yml@main

uses: mpvkit/BuildShared/.github/workflows/check_version.yml@v1.0.0

Copilot · 2026-02-02T07:50:23Z

.github/workflows/build.yml

-    uses: mpvkit/action/.github/workflows/build.yml@main
+    permissions:
+      contents: write
+    uses: mpvkit/BuildShared/.github/workflows/build.yml@main


Using '@main' branch for the reusable workflow is not recommended for production as it can introduce breaking changes unexpectedly. Consider pinning to a specific version tag or commit SHA for stability and predictability. For example: uses: mpvkit/BuildShared/.github/workflows/[email protected].

Suggested change

uses: mpvkit/BuildShared/.github/workflows/build.yml@main

uses: mpvkit/BuildShared/.github/workflows/build.yml@v1.0.0

Copilot · 2026-02-02T07:50:23Z

Sources/BuildScripts/XCFrameworkBuild/base.swift

+typealias PackageTarget = BuildShared.PackageTarget
+typealias PlatformType = BuildShared.PlatformType
+typealias ArchType = BuildShared.ArchType
+typealias Utility = BuildShared.Utility


Missing type aliases for BuildShared components that are used in main.swift. The following type aliases should be added:

typealias BaseBuild = BuildShared.BaseBuild (used in multiple classes in main.swift)

typealias ArgumentOptions = BuildShared.ArgumentOptions (used on line 5 of main.swift)

typealias BuildRunner = BuildShared.BuildRunner (used on line 6 of main.swift)

typealias SharedBuildOptions = BuildShared.SharedBuildOptions (used throughout main.swift for releaseVersion)

Without these type aliases, the code in main.swift will not compile as it references these types without qualification.

Suggested change

typealias Utility = BuildShared.Utility

typealias Utility = BuildShared.Utility

typealias BaseBuild = BuildShared.BaseBuild

typealias ArgumentOptions = BuildShared.ArgumentOptions

typealias BuildRunner = BuildShared.BuildRunner

typealias SharedBuildOptions = BuildShared.SharedBuildOptions

Copilot · 2026-02-02T07:50:23Z

Sources/BuildScripts/XCFrameworkBuild/main.swift

        super.init(library: .libass)
    }

+    override func flagsDependencelibrarys() -> [any BuildLibrary] {


The method name 'flagsDependencelibrarys' appears to have a typo. It should likely be 'flagsDependenceLibraries' or 'flagsDependencyLibraries' for proper English spelling and Swift naming conventions. This should match the method name in the BuildShared.BaseBuild class. Please verify the correct spelling used in BuildShared and update accordingly.

Suggested change

override func flagsDependencelibrarys() -> [any BuildLibrary] {

override func flagsDependencyLibraries() -> [any BuildLibrary] {

Copilot · 2026-02-02T07:50:24Z

Sources/BuildScripts/Package.swift

    products: [
    ],
+    dependencies: [
+        .package(url: "https://github.com/mpvkit/BuildShared.git", branch: "main"),


Using 'branch: "main"' for the BuildShared dependency is not recommended for production code as it can lead to unpredictable builds when the main branch changes. Consider using a specific version tag or commit hash instead for reproducible builds. For example: .package(url: "https://github.com/mpvkit/BuildShared.git", from: "1.0.0") or .package(url: "https://github.com/mpvkit/BuildShared.git", exact: "1.0.0").

Suggested change

.package(url: "https://github.com/mpvkit/BuildShared.git", branch: "main"),

.package(url: "https://github.com/mpvkit/BuildShared.git", from: "1.0.0"),

Initial plan

966f8e6

Copilot AI assigned Copilot and cxfksword Feb 2, 2026

Copilot started work on behalf of cxfksword February 2, 2026 03:58 View session

Copilot AI and others added 2 commits February 2, 2026 04:20

refactor build scripts to use BuildShared

9af96a5

Co-authored-by: cxfksword <[email protected]>

add workflow permissions for BuildShared reuse

b51a90d

Co-authored-by: cxfksword <[email protected]>

Copilot AI changed the title ~~[WIP] Refactor project to use BuildShared library and update GitHub Actions~~ Refactor libass build to use BuildShared and shared workflows Feb 2, 2026

Copilot AI requested a review from cxfksword February 2, 2026 04:27

Copilot finished work on behalf of cxfksword February 2, 2026 04:27

cxfksword marked this pull request as ready for review February 2, 2026 07:45

Copilot AI review requested due to automatic review settings February 2, 2026 07:45

Copilot started reviewing on behalf of cxfksword February 2, 2026 07:45 View session

cxfksword reviewed Feb 2, 2026

View reviewed changes

Sources/BuildScripts/XCFrameworkBuild/base.swift

Copy link

Contributor

cxfksword Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接删除Base.swift

Copilot AI reviewed Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor libass build to use BuildShared and shared workflows #5

Refactor libass build to use BuildShared and shared workflows #5

Uh oh!

Copilot AI commented Feb 2, 2026 •

edited

Loading

Uh oh!

cxfksword Feb 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	uses: mpvkit/BuildShared/.github/workflows/check_version.yml@main
	uses: mpvkit/BuildShared/.github/workflows/check_version.yml@v1.0.0

-typealias Utility = BuildShared.Utility
+typealias Utility = BuildShared.Utility
+typealias BaseBuild = BuildShared.BaseBuild
+typealias ArgumentOptions = BuildShared.ArgumentOptions
+typealias BuildRunner = BuildShared.BuildRunner
+typealias SharedBuildOptions = BuildShared.SharedBuildOptions

	override func flagsDependencelibrarys() -> [any BuildLibrary] {
	override func flagsDependencyLibraries() -> [any BuildLibrary] {

	.package(url: "https://github.com/mpvkit/BuildShared.git", branch: "main"),
	.package(url: "https://github.com/mpvkit/BuildShared.git", from: "1.0.0"),

Refactor libass build to use BuildShared and shared workflows #5

Are you sure you want to change the base?

Refactor libass build to use BuildShared and shared workflows #5

Uh oh!

Conversation

Copilot AI commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

cxfksword Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 2, 2026 •

edited

Loading