Add desktop QR-code button to iOS download page - #1654
Open
slightlyoffbeat wants to merge 4 commits into
Open
Conversation
Desktop visitors to /download/ios can't install from the App Store link, so show a "Get it for mobile" button that opens a QR-code modal instead. iOS/Android/other visitors still get the App Store button. QR is a placeholder (WIP): it encodes the App Store URL for now; destination and unique tracking token to be finalized before launch.
slightlyoffbeat
marked this pull request as ready for review
August 7, 2026 02:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 88.15% 88.43% +0.28%
==========================================
Files 167 171 +4
Lines 11600 12093 +493
==========================================
+ Hits 10226 10695 +469
- Misses 1374 1398 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
knowler
reviewed
Aug 12, 2026
knowler
left a comment
knowler
left a comment
Collaborator
There was a problem hiding this comment.
Similar to #1699 (comment), I think we we should include a link alternative for the QR code, since that’d better serve screen reader and keyboard users.
Comment on lines
+80
to
+87
| <include:button | ||
| extra_classes="fl-dialog-trigger fl-store-button" | ||
| label="{{ ftl('download-get-it-for-mobile') }}" | ||
| analytics_text="Get it for mobile" | ||
| analytics_position="download-intro" | ||
| analytics_id="ios-qr-modal" | ||
| data_target_id="ios-qr-modal" | ||
| /> |
Collaborator
There was a problem hiding this comment.
Should we add a device-mobile icon to this button as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Add a desktop-only QR-code button to the iOS download page so visitors who can't install from the App Store link can scan to get Firefox on their phone.
Significant changes and points to review
cms/download_page.html(iOS branch only) — This is the main change and the thing to review. The page is shared by all six platform download pages; the change is scoped strictly to thepage.platform == "ios"branch. Desktop visitors (windows/osx/linux) now see a "Get it for mobile" button that opens a QR-code modal (fl-dialog); everyone else (ios/android/other) still gets the existing App Store button. Show/hide is the existingconditional-displayCSS mechanism keyed off the platform classsite.jsputs on<html>— both buttons render in the HTML and CSS gates visibility. No new JS/CSS: the modal reuses the Flare dialog (setupDialogs) and QR (qrcode_rounded) already loaded viabase-flare.html.l10n/en/cms/download.ftl(download-get-it-for-mobile,download-scan-to-get) in the CMS Fluent namespace (scoped to CMS locales), wired viaDownloadPage.ftl_files./browsers/mobile/page vs. App Store deep-link) and (2) a QR-specific tracking token. Marked with aTODO (WIP)in the template. Please don't merge until that's resolved.Testing
/download/ios.<html>element and edit itsclass:ios→ App Store button shows, QR button hidden.windows/osx/linux→ QR button shows, App Store hidden.android/other→ App Store button shows (fallback)./download/,/download/android, etc.) are unchanged.