Skip to content

Try 2 bias values when calling originalPositionFor from applySourceMap #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try 2 bias values when calling originalPositionFor from applySourceMap #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51ae5d
Try 2 bias values when calling originalPositionFor from applySourceMap.
Jan 20, 2019
816509d
Fix error with undefined SourceMapConsumer
Jan 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/source-map-generator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const base64VLQ = require("./base64-vlq");
const util = require("./util");
const ArraySet = require("./array-set").ArraySet;
const MappingList = require("./mapping-list").MappingList;

const BasicSourceMapConsumer = require("./source-map-consumer").BasicSourceMapConsumer;
/**
* An instance of the SourceMapGenerator represents a source map which is
* being built incrementally. You may pass an object with the following
Expand Down Expand Up @@ -200,11 +200,19 @@ class SourceMapGenerator {
// Find mappings for the "sourceFile"
this._mappings.unsortedForEach(function(mapping) {
if (mapping.source === sourceFile && mapping.originalLine != null) {

// Check if it can be mapped by the source map, then update the mapping.
const original = aSourceMapConsumer.originalPositionFor({
let generatedPosition = {
line: mapping.originalLine,
column: mapping.originalColumn
});
column: mapping.originalColumn,
bias: BasicSourceMapConsumer.GREATEST_LOWER_BOUND
};
let original = aSourceMapConsumer.originalPositionFor(generatedPosition);
if (original.source === null) {
generatedPosition.bias = BasicSourceMapConsumer.LEAST_UPPER_BOUND;
original = aSourceMapConsumer.originalPositionFor(generatedPosition);
}

if (original.source != null) {
// Copy mapping
mapping.source = original.source;
Expand Down