-
Notifications
You must be signed in to change notification settings - Fork 823
Add SUMO rules mentions & Improve AAQ step 3 #7114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add SUMO rules mentions when creating/editing a question, an answer, a forum thread, a forum post, a KB forum thread or a KB forum post. In AAQ step 3, replace "Subject:" with "Summarize your question" and add help text for this field. In AAQ step 3, display the Troubleshooting Info help text above the Share Data button, right after the field name. In AAQ step 3, add the "tb_version" extra field. In AAQ step 3, autofill the OS version field for Thunderbird. Fix the issue with the Share Data button not working when editing a question. Do not display the Common responses button when editing a question. Improve accessibility. Use "Windows 10/11" when there is not enough info to identify the exact Windows NT 10.0 version.
|
I like your changes. Only i would make the note about following the guidelines on a new line, so it is more notable. |
|
Keen to understand this one more "- Do not display the Common responses button when editing a question." Why is this important? |
|
Hi Dennys, As always, thanks for being proactive. Really appreciate your initiative to work on these improvements. Generally, I like the direction of these changes. I think the first one is especially needed for our forum. It'll be great if we can seek feedback from someone with UX expertise to help advise with the copy and the text placing itself. Also, I'm not sure if it's a good idea to mix bunch of changes into 1 PR. At least, I'm pretty sure the other improvements on the AAQ page will need to be discussed on the product level. So I won't comment much on that and will defer them to platform team. |
|
@plwt that's not important at all, but since we (correctly) do not display this button when creating a question, it makes perfect sense not to display it when editing a question too. A common response can't be the question content anyway, so... |
|
@kelimuttu Thank you for your feedback! If you know someone with UX experience, please ask them to take a look. Unfortunately, I'm not sure who to contact here. Regarding the changes. First, the platform team will have to review this PR anyway before merging, so they will share their opinion and will request changes if necessary. Second, the only major change, except for the first one, is the second one (with the Subject field). The reason I included it in this PR is that it's the only way to do it at once and avoid merging conflicts. Another option is to wait until this PR is marked as ready for review, reviewed and merged, and then open another one. If you are not sure about the changes to the Subject field, though, I can remove them from this PR. |
|
(The test failures are unrelated now) |
|
@denyshon let me ask internally to see what UX resources are available. At least for the copy, we can loop in Donna or Abby. As for the PR, I'll defer it to the platform team since they know more. For the update on the "Subject" copy, we can also ask Donna/Abby for feedback. |
|
@wsmwk has requested a placeholder for the "tb_version" field. Here's how the Thunderbird AAQ step 3 looks now: |
Sounds good to me - glad it is included, no problems here. :-) |

Changes
Resolves #2196, #2536, #1642, #2700.
Screenshots
AAQ step 3 (Firefox): [click to expand]
AAQ step 3 (Firefox) after clicking the Share Data button, in case we failed to pull the data: [click to expand]
AAQ step 3 (Thunderbird): [click to expand]
An example of how the editor looks on the updated surfaces (except for questions): [click to expand]
Note: Some icons in the screenshots may be missing because they were taken on a test setup.
TODO
Add l10n comments once the strings are finalized.