Skip to content

CMS springboard tweaks - #17326

Merged
stephaniehobson merged 1 commit into
mainfrom
cms-tweaks
Aug 11, 2026
Merged

CMS springboard tweaks#17326
stephaniehobson merged 1 commit into
mainfrom
cms-tweaks

Conversation

@stephaniehobson

Copy link
Copy Markdown
Contributor

One-line summary

CMS springboard tweaks

Significant changes and points to review

Tweaks to the springboard component based on observations in user training.

  • Only select "type" once, use it for both icon and text label
  • Reduce repetitive labels
  • Use the "preview" text for the label when the block is collapsed

Issue / Bugzilla link

n/a

Testing

View/edit the homepage with existing data.

@stephaniehobson
stephaniehobson requested review from a team as code owners August 4, 2026 19:09
@stephaniehobson stephaniehobson added the Needs Review Awaiting code review label Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.93%. Comparing base (b843b13) to head (4713746).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17326      +/-   ##
==========================================
- Coverage   82.95%   82.93%   -0.02%     
==========================================
  Files         179      179              
  Lines        9362     9377      +15     
==========================================
+ Hits         7766     7777      +11     
- Misses       1596     1600       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

link_attributes=item.preview,
type=item.type,
type_icon=item.icon,
type_icon=item.type,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are we confident that these two are interchangeable? icon was always all-lowercase but type looks like it's title case/has a leading capital. Is that handled at template render? The test, below, deliberately downcases to match a string in the HTML, so I am assuming it's handled already

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon function lowercases it 👍

@stevejalim stevejalim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CMS springboard editor to derive icons from content type and improve editor labels.

Changes:

  • Removes the redundant icon field and derives icons from type.
  • Refines CMS choices, help text, and collapsed labels.
  • Updates migration, fixtures, factories, and rendering tests.

Reviewed using the repository’s custom guidance. Safe to merge with no identified follow-ups.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
bedrock/mozorg/blocks/common.py Simplifies springboard fields and editor labels.
bedrock/mozorg/migrations/0045_alter_homepage_content.py Updates the homepage StreamField schema.
bedrock/mozorg/templates/mozorg/cms/blocks/springboard_block.html Uses type for the icon.
bedrock/mozorg/fixtures/springboard_fixtures.py Removes redundant fixture icons.
bedrock/mozorg/tests/factories.py Updates the item factory schema.
bedrock/mozorg/tests/test_blocks.py Verifies type-derived icon classes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@stephaniehobson
stephaniehobson merged commit 3515bb4 into main Aug 11, 2026
7 checks passed
@stephaniehobson
stephaniehobson deleted the cms-tweaks branch August 11, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants