WT-334 - Build CMS Components For Advertising Pages - Part 3 - #16815
Merged
dchukhin merged 240 commits intoNov 24, 2025
Conversation
…dark-section css files
…ol, and m24 sizing.
…o mozorg/advertising/landing.html
kkellydesign
requested review from
janbrasna and
stevejalim
and removed request for
janbrasna
November 23, 2025 20:46
stevejalim
approved these changes
Nov 24, 2025
|
|
||
|
|
||
| @require_safe | ||
| def contact(request): |
Contributor
There was a problem hiding this comment.
This page still appears to be inert in terms of handling form submissions
| FieldPanel("linkedin_link", heading="Linkedin Link"), | ||
| FieldPanel("tiktok_link", heading="Tiktok Link"), | ||
| FieldPanel("spotify_link", heading="Spotify Link"), | ||
| FieldPanel("twitter_link", heading="Twitter Link"), |
Contributor
There was a problem hiding this comment.
As per prev comment about Twitter links in general, plus naming of the site
| max_length=255, | ||
| blank=True, | ||
| ) | ||
| twitter_link = models.URLField( |
Contributor
There was a problem hiding this comment.
As mentioned in an earlier PR, I'm not sure we use Twitter any more. Also if we do, it's no longer called by that name
Co-authored-by: Steve Jalim <stevejalim@mozilla.com>
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…334-cms-components-for-advertising-sub-navigation
Base automatically changed from
WT-334-cms-components-for-advertising-subpage
to
main
November 24, 2025 21:17
dchukhin
deleted the
WT-334-cms-components-for-advertising-sub-navigation
branch
November 24, 2025 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request depends on #16814, which should be reviewed first
One-line summary
This pull request makes the advertising sub-navigation editable through Wagtail.
Significant changes and points to review
Following the work in #16814, this pull request adds
NavigationLinkBlockwith the fields necessary for navigation links (types of links are: 1. a block on the Advertising index page, 2. an internal page, 3. an external link)sub_navigationstreamfield toAdvertisingIndexPage, so users can create multiple items in the sub-navigationAdvertisingIndexPage, verifying that subnavigation items are valid (can't choose a non-existent block, can't remove a block that's being used as a link, etc.)Also, the following changes from #16848 have been merged into this branch:
ContentSubpageas a child ofAdvertisingIndexPageStatisticCalloutBlockandStatisticBlockFeatureListWithModalsBlock,FeatureItemWithModalBlock, andFigureBlockAlso, the following changes from #16860 have been merged into this branch:
AdvertisingIndexPageandContentSubpagenow more closely match the pattern used on springfield by nesting the existingcontentdata inside of asectionsfield:sectionsfield is a streamfield ofSectionBlocksSectionBlockhas acontentstreamblock that can have any of the blocks previously in theAdvertisingIndexPageandContentSubpagecontentfieldSectionBlockalso has a collapsed settings, which can set the section id, whether the section should have a divider on top (moved here from the nested blocks), and whether the section should have a dark background (moved here from the nested blocks)Issue / Bugzilla link
WT-334
Testing
To test locally, go to Wagtail and create/edit an "Advertising index page" page in the page tree, and create a sub-navigation in the "Settings" panel. Try to make the sub-navigation identical to what is on http://localhost:8000/en-US/advertising/. Also, verify that the same sub-navigation exists on all children of the Advertising index page.