Add support for custom hash calculation function, allowing content streaming#92
Open
idangutman-ms wants to merge 1 commit intomozilla-services:masterfrom
Open
Conversation
|
Hello @idangutman-ms. You may want to check out #73 and #88 and perhaps submit this to https://github.com/smallstep/pkcs7 or another fork. FYI and thanks! |
|
This has been completed in smallstep#41, and was released in v0.2.0 of https://github.com/smallstep/pkcs7 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change provides the ability to add a custom function for calculating the content hash.
This is useful for calculating the hash of the content as it is being streamed, instead of requiring the entire content to be loaded into memory, and is necessary for calculating hashes on large files without excessive memory usage.
Example for usage can be seen in test file, where instead of setting
p7.Content, we use thep7.HashCalc(settingContentis optional when usingHashCalc):