Accept the empty string as a falsy value for build_number in list_releases #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrownmozilla
approved these changes
Jul 22, 2024
Contributor
gbrownmozilla
left a comment
gbrownmozilla
left a comment
There was a problem hiding this comment.
I'm not sure I understand the issue, but this seems worth trying.
jcristau
requested changes
Jul 23, 2024
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
This feels like it should be fixed in the frontend, to not send a null value...
| releases = releases.filter(Release.version == version) | ||
| if build_number: | ||
| releases = releases.filter(Release.build_number == build_number) | ||
| releases = releases.filter(Release.build_number == int(build_number)) |
Contributor
There was a problem hiding this comment.
If build_number is not an int this will raise ValueError and presumably turn into a 500, which we don't want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1530