Implement a mark-as-merged action for shipitscript (bug 1890753) #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
approved these changes
Dec 23, 2025
| # ACTION_MAP {{{1 | ||
| ACTION_MAP = { | ||
| "mark-as-shipped": mark_as_shipped_action, | ||
| "mark-as-merged": mark_as_merged_action, |
Contributor
There was a problem hiding this comment.
Did you consider making a single action called "mark-completed" or something that can handle both? Or is that not really viable due to how releases vs merges are handled in shipit?
Contributor
Author
There was a problem hiding this comment.
It could be possible I guess, although it might get a bit crafty because we don't want to be able to call mark-as-shipped from merge automation for example. And since we rely on scopes for the action instead of the payload, I don't think it's worth adding a second scope onto everything.
ahal
requested changes
Dec 23, 2025
Contributor
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Ah didn't mean to approve due to the tox failures, but looks good barring that.
Eijebong
force-pushed
the
shipit-mark-as-merged
branch
from
60f74d3 to
8a14a06
Compare
Eijebong
force-pushed
the
shipit-mark-as-merged
branch
from
8a14a06 to
3de6d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is getting implemented as part of mozilla-releng/shipit#1801