Parse Firefox VPN versions using StrictVersion #3565
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
force-pushed
the
vpn-strictversion
branch
from
af02e62 to
c91449e
Compare
As far as I can tell, version numbers have only ever contained digits and periods, so we can do without LooseVersion here, reject bad version strings, and ensure comparisons work. Update tests to not use 4-part version numbers, that haven't actually been used in practice, and are rejected by StrictVersion. Fixes mozilla-releng#3441
jcristau
force-pushed
the
vpn-strictversion
branch
from
c91449e to
7518d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, version numbers only contain digits and periods, so we can do without LooseVersion here, reject bad version strings, and ensure comparisons work.
Fixes #3441