Test corrade_add_resource() with Unicode filenames#49
Open
Conversation
11 tasks
It's used just during the build, and in the ResourceCompileTest.
7028980 to
82c1d0c
Compare
4c00095 to
e224b5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While everything works great on Linux and macOS, this causes CMake with Ninja on Windows to go into an infinite loop. As far as I know, this didn't happen with MinGW makefiles, so shouldn't be an issue with my CMake dependency handling code. It also doesn't seem to happen with VS project files, so probably just related to Ninja on Windows (and/or CMake Ninja support).
Putting this here so it doesn't get forgotten.
Things left to do:
maybe it's finally fixed five years later?not really, what am I doing wrong?