Skip to content

Render stored raw response in ui to let user view their keyword search response from google#39

Open
mosharaf13 wants to merge 3 commits into
mainfrom
render-stored-html-in-ui
Open

Render stored raw response in ui to let user view their keyword search response from google#39
mosharaf13 wants to merge 3 commits into
mainfrom
render-stored-html-in-ui

Conversation

@mosharaf13
Copy link
Copy Markdown
Owner

@mosharaf13 mosharaf13 commented Feb 25, 2023

Resolves #35

The user can now view raw response from google. The rendered page of google currently has some bugs listed below.

  • Js variables are showing as undefined. So, js related functionalities is unavailable currently at the moment.
  • Right sidebar UI breaks. It goes way below than expected.
  • In small screens we are seeing desktop view.
  • Other inconsistencies like search button doesn't work here.

I have attached screenshots for your better understanding.

  • For Js variables undefined inconsistency I am thinking that these being called before being defined. So, we will have to find a way to make sure all the js files loads and initialization happens before any of them gets called. Your suggestion regarding the issue would be really helpful.
  • For Right sidebar broken UI . I am not sure what's causing this problem. In networks tab I am seeing two .webp asset having local url instead of googe's. But, other than that I am not seeing any css related errors.
  • In small screens we are seeing desktop view. I am guessing once we take care of the js undefined issue, we can have a better understanding of why this problem is happening.

To debug these issues I need more time. If you could let me know, what's specific targets we are trying to achieve on this page that would be really helpful for me to estimate the duration for the completion of this feature.

Thanks for designing this problem. I had fun solving it. Learned some new things about google search page.

js_not_defined
css_breakdown

@olivierobert
Copy link
Copy Markdown

How use an iframe instead and add the HTML content via the attribute srcdoc? While iframes are not usually the best method to render content, they do seem to be the best approach to isolate the scraped content from the host application.

@mosharaf13
Copy link
Copy Markdown
Owner Author

I did the feature with an iframe first. Then I thought users might have pop up blocker installed in their browsers. So, I reverted back to showing the rendered scrapped content in a separate page. In terms of UX, I am wondering if using a modal would be a better option than these two. User won't have to go to different tab to view the page, and there's no possibility of any third party extension blocking the view of the modal. What's your thoughts on that? Should we go for iframes? or should we show the scrapped content in a modal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Render the stored HTML in the UI

2 participants