Skip to content

[WIP] Support compose-rl + FSDP2 changes #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rithwik-db wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Support compose-rl + FSDP2 changes #3898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions composer/utils/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,15 @@ def is_model_ddp(model: torch.nn.Module) -> bool:
def is_model_fsdp(model: torch.nn.Module) -> bool:
"""Whether ``model`` is an instance of a :class:`.FullyShardedDataParallel`."""
try:
from torch.distributed.fsdp import FSDPModule
from torch.distributed.fsdp import FullyShardedDataParallel as FSDP

if isinstance(model, FSDP):
if isinstance(model, (FSDP, FSDPModule)):
return True

# Check if model is wrapped with FSDP
for _, obj in model.named_children():
if isinstance(obj, FSDP):
if isinstance(obj, (FSDP, FSDPModule)):
return True
return False
except ImportError:
Expand Down
Loading