feat(vault-v1&2): add factory check in fetch utilities #504
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1b6f004ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c426f643dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/blue-sdk-viem/src/fetch/vault-v2/VaultV2MorphoMarketV1Adapter.ts
Show resolved
Hide resolved
Foulks-Plb
changed the title
…in fetchVault function
…andling and code formatting
| import {IMorphoMarketV1AdapterV2Factory} from "./interfaces/IMorphoMarketV1AdapterV2Factory.sol"; | ||
| import {IVaultV2Factory} from "./interfaces/IVaultV2Factory.sol"; | ||
|
|
||
| error UnknownFromFactory(address factory, address vault); |
There was a problem hiding this comment.
| error UnknownFromFactory(address factory, address vault); | |
| error UnknownOfFactory(address factory, address vault); |
no?
There was a problem hiding this comment.
What did I do?
What’s your proposal?
There was a problem hiding this comment.
Just the naming "unknown of" seems more appropriate than "unknown from"!
But actually, it may even be better to say "unknwon to": https://chatgpt.com/share/e/697b0e61-edd0-8004-a49d-8f965d6d62df
| error UnknownFromFactory(address factory, address vault); | |
| error UnknownToFactory(address factory, address vault); |
There was a problem hiding this comment.
Mmm i prefer UnknownOfFactory:
Because it means the object is valid but does not belong to this factory (it was created by another one or the ownership link is incorrect).
And UnknownToFactory is not the destination of the call (the factory is correct), but the ownership relationship between the object and that factory.
…vaults-in-sdk-fetchers-v1-and-2
Uh oh!
There was an error while loading. Please reload this page.