Skip to content

Update 2027 07 31 - #122

Merged
MathisGD merged 4 commits into
mainfrom
update-2027-07-31
Aug 19, 2026
Merged

Update 2027 07 31#122
MathisGD merged 4 commits into
mainfrom
update-2027-07-31

Conversation

@QGarchery

@QGarchery QGarchery commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@QGarchery
QGarchery requested a review from MathisGD July 31, 2026 09:00
@QGarchery QGarchery self-assigned this Jul 31, 2026
MathisGD
MathisGD previously approved these changes Aug 18, 2026
peyha
peyha previously approved these changes Aug 19, 2026

@peyha peyha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the CI is failing (ALCHEMY_KEY should be set)

foundry.toml now builds the fork URL from [rpc_endpoints] ethereum = ".../${ALCHEMY_KEY}", so the raw ETH_RPC_URL is no longer read.
@claude
claude Bot dismissed stale reviews from peyha and MathisGD via 16d2ddc August 19, 2026 13:10
@MathisGD
MathisGD merged commit 16b8491 into main Aug 19, 2026
3 checks passed
@MathisGD
MathisGD deleted the update-2027-07-31 branch August 19, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constructor missing zero guard for SCALE_FACTOR — silent price() = 0 on misconfigured deployments Improve forking method in tests (low prio)

4 participants