refactor: stabilize Go tests and adapters - #267
Merged
Conversation
Add t.Setenv isolation for npm_command and npm_lifecycle_event in 6 upgrade tests and the shared setupUpgradeActivationTest helper. Without these, discoverInstallation() short-circuits to npx context when tests run inside an npx-launched process, causing all non-npx upgrade tests to fail.
morluto
marked this pull request as ready for review
August 3, 2026 11:11
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactor stabilizes the Go test and adapter boundaries while preserving existing behavior.
Review order
internal/mcpserver/schemas.goandinternal/mcpserver/schemas_test.gointernal/corpus/corpus_test.goandinternal/corpus/corpus_fixture_test.gointernal/cli/cli.goandinternal/cli/dispatch.goTesting
npm_command=exec npm_lifecycle_event=npx go test ./... -count=1— passedmake verify— passedmake test-race— passedmake lint-full— 0 issuesgofmtandgit diff --check— passedCompatibility and scope
internal/app/mcppackage extraction and exhaustive sleep replacement are intentionally deferred; the existing MCP implementation remains split across its capability-specificinternal/app/mcp_*.gofiles.