rewrite login end-points to use unified service#226
Open
pythys wants to merge 1 commit intomoqui:masterfrom
Open
rewrite login end-points to use unified service#226pythys wants to merge 1 commit intomoqui:masterfrom
pythys wants to merge 1 commit intomoqui:masterfrom
Conversation
Member
|
From a read through the code changes there are changes to the functionality so I am not confident in merging this until some testing is done of the various flows involved in login with and without a second factor required, and with correct and incorrect password and MFA code. If someone else would like to help with this, please list the test scenarios you run and the results. I'll get to this sooner or later but am ill right now, and I see this as a lower priority as it is a code de-dup/cleanup effort more than a needed functional change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this depends on first approving this PR on the moqui framework