Add condition and evaluate type for container macro#223
Open
acetousk wants to merge 5 commits intomoqui:masterfrom
Open
Add condition and evaluate type for container macro#223acetousk wants to merge 5 commits intomoqui:masterfrom
acetousk wants to merge 5 commits intomoqui:masterfrom
Conversation
Member
|
This is a basic/core enough element that the condition should be supported for the other render modes before merging this. Feel free to do so, or I'll get to it sooner or later... |
Member
Author
|
@jonesde I added the vapps and apps rendermode to the condition attribute changes. Let me know if I should add any of the other render modes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This evaluates the container macro type attribute for scenarios where the element needs context data, and adds a condition for conditional display of the container.