Contribute documentation and update romanian currency#665
Open
grozadanut wants to merge 2 commits intomoqui:masterfrom
Open
Contribute documentation and update romanian currency#665grozadanut wants to merge 2 commits intomoqui:masterfrom
grozadanut wants to merge 2 commits intomoqui:masterfrom
Conversation
Member
|
Hey @grozadanut, It looks like this is a non-backwards compatible change that will break existing code. To keep it as backwards compatible as possible, I'd just change the abbreviation instead of the uomId. I'd accept the documentation contributions in a different pr. |
Author
|
What do you mean it's non-backwards compatible? Where is the ROL uomId referenced? ROL and RON are two different units of measure, ROL was valid until 2005, after which it was replaced by RON, by cutting 4 zeros. If there are people that use ROL in some legacy Moqui projects, then they can simply keep the old ROL uom record and add a new uom record for RON. I would not mix ROL uomId with RON abbreviation, it doesn't make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated .xsd documentation from using data from https://www.moqui.org/m/docs/framework/User+Interface/XML+Screen