Improvement: Removed the idle timeout limit of 30s on RestClient#660
Open
puru-khedre wants to merge 1 commit intomoqui:masterfrom
Open
Improvement: Removed the idle timeout limit of 30s on RestClient#660puru-khedre wants to merge 1 commit intomoqui:masterfrom
puru-khedre wants to merge 1 commit intomoqui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Even after setting a higher timeout limit in the REST client, it doesn't help because the maximum limit is capped at 30s.
Description:
Removed the Idle Timeout on the RestClient, instead using the
timeoutSeconds - 1(timeoutSeconds is a RestClient class variable).This update allows waiting for a longer time in specific situations where Rest APIs generally take a longer duration to respond. For example, it would help run bulk indexing on the opensearch/elasticsearch.
Previous commit where the timeout was initially implemented
In RestClient if a timeout is set, set timeout-1 as the idle timeout on the connection, otherwise the Jetty client seems to wait 30s anyway (30s is the default idle timeout)