Make it easier to create a related task#139
Open
acetousk wants to merge 9 commits intomoqui:masterfrom
Open
Conversation
…ields Update Task's Worker dropdown to not assume a type of Party
Member
|
This looks good aside from the create transition: it is better to use a single service so that validations from service in-parameters are used in the form on the screen; the create WorkEffortAssoc could be added to the existing create#Task service to handle this, or a separate service that does both could be used (adding this to the create#Task service might be easiest/best) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do a squash merge