Fix cd command hook bug and add an option to disable it#485
Open
Inndy wants to merge 2 commits intomoovweb:masterfrom
Open
Fix cd command hook bug and add an option to disable it#485Inndy wants to merge 2 commits intomoovweb:masterfrom
cd command hook bug and add an option to disable it#485Inndy wants to merge 2 commits intomoovweb:masterfrom
Conversation
`cd $*` is wrong, passing down command arguments should use "$@" instead ref: https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and#94135
Inndy
changed the title
cd command hook bugcd command hook bug and add an option to disable it
djylb
added a commit
to djylb/gvm
that referenced
this pull request
Sep 15, 2025
|
👍 to this PR, even though it could be better if we by default disable the auto version switch at the beginning. :( 👎 to this one, since it doesn’t take performance into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been bothered by the "-bash: cd: too many arguments" error for a while and just discovered the cause.
Additionally, the
cdcommand hook is causing notable slowdowns. Please ensure future PRs are reviewed thoroughly to avoid such issues.ref: https://unix.stackexchange.com/questions/41571/what-is-the-difference-between-and#94135