Skip to content

Conversation

@bucaojit
Copy link
Member

This change adds a check for authentication mechanism properties ENVIRONMENT and TOKEN_RESOURCE.
For azure and gcp both properties will be specified. For k8s only ENVIRONMENT needs to be specified.

Added unit tests to check that the human flow callback is added when the machine flow properties are not set.

Ran manual tests using the mongo-java-driver OIDC machine flow tests. I added in their script a few lines to check out my JDBC changes and run our Main.java test file.

The working patch with my changes. The azure and gcp tasks pass. The k8s one has a missing dependency error. I'll create a ticket to address that, for now the azure passing is the important one.
https://spruce.mongodb.com/version/6903ab0757a7fa0007359575/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Failing patch without changes:
https://spruce.mongodb.com/version/6903ba07f4fc530007ce6899/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

@bucaojit bucaojit requested a review from a team as a code owner October 30, 2025 23:51
relocate 'com.google', 'shadow.com.google'
relocate 'com.nimbusds', 'shadow.com.nimbusds'
relocate 'net.jcip', 'shadow.net.jcip'
relocate 'net.minidev', 'shadow.net.minidev'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to the human flow. I was testing it manually to verify all is well and I get an error ☹️. So this must have been broken since the shadow change went in:

Caused by: java.lang.NoClassDefFoundError: shadow/net/minidev/json/JSONAware

Copy link
Collaborator

@nbagnard nbagnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

Copy link
Collaborator

@jchemburkar jchemburkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants