GODRIVER-3690 Add ErrorCodesFrom to the mongo package #2241
+96
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the CommandFailedEvent structure to include error codes, addressing GODRIVER-3690. The change enables users to access error codes directly from command failure events without parsing the error themselves.
Key changes:
- Added a
Codesfield toCommandFailedEventto expose error codes - Implemented
errorCodes()helper function to extract codes from driver errors - Added test coverage for the new field
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| event/monitoring.go | Added Codes field to CommandFailedEvent structure |
| x/mongo/driver/operation.go | Populates the new Codes field when publishing failed events; removed blank line |
| x/mongo/driver/errors.go | Implemented errorCodes() function to extract error codes from driver errors |
| mongo/errors.go | Refactored variable declarations to use var() block (style change) |
| internal/integration/clam_prose_test.go | Added test case for CommandFailedEvent.Codes; removed blank line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
🧪 Performance ResultsCommit SHA: 58198cfThe following benchmark tests for version 692f82f467740700079be35b had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
Contributor
API Change Report./v2/mongocompatible changesErrorCodesFrom: added |
prestonvasquez
force-pushed
the
feature/godriver-3690-extend-event-failures-with-error-codes
branch
2 times, most recently
from
3b7f589 to
63d4781
Compare
prestonvasquez
force-pushed
the
feature/godriver-3690-extend-event-failures-with-error-codes
branch
from
63d4781 to
58198cf
Compare
prestonvasquez
added
review-priority-normal
prestonvasquez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3690
Summary
Add an
ErrorCodesFromfunction that can be used to parse server error codes from an arbitrary Go error.Background
Would be convenient to get server status codes without caller taking a dependency on the experimental API. For example, OpenTelemetry needs to include
db.response.status.codefor otelmongo: open-telemetry/opentelemetry-go-contrib#7983 (comment)An alternative to this design would be to put
Codesonevent.CommandFailedEvent. Suggest we forgo this solution for two reasons:event.CommandFailedEvent