Use POSIX on Windows when building with mingw-w64 toolchain #1098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CXX-3180. Addresses the following compilation error observed when built with mingw-w64 GCC on Windows:
Given systems where mingw-w64 GCC toolchains are installed typically include the POSIX library, this PR propoes restricting the conditions used to select Windows headers to "building with MSVC" (
defined(_MSC_VER)) only instead of "targeting Windows" (defined(_WIN32)).(There is the possibility that
_WIN32_WINNTcould be used per this SO post, but I'd prefer not to introduce Windows-specific library configuration macros if we can help it.)