[LG-5721] chore: Validation Cleanup #3299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75dc556 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adamrasheed
requested review from
a team,
stephl3 and
tsck
and removed request for
a team
Copilot finished reviewing on behalf of
adamrasheed
November 11, 2025 22:27
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs validation cleanup to address warnings from the pnpm command. The changes focus on removing unused dependencies and reorganizing package classifications between production dependencies and devDependencies.
Key Changes:
- Removed unused dependencies across 40+ packages (e.g.,
xml2json,@lg-tools/test, various UI component cross-references) - Moved test-only and development-only dependencies to
devDependencies(e.g.,lodash,polished,@lg-tools/test-harnesses) - Updated dependency versions:
globfrom10.3.12to^11.0.0,@eslint/compatfrom^1.2.3to^1.2.4
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/validate/package.json | Removed unused @lg-tools/test from devDependencies |
| tools/test/package.json | Moved @lg-tools/build and @lg-tools/meta to devDependencies as they're only used for building the test package itself |
| tools/storybook-addon/package.json | Removed 11 unused polyfill and utility packages |
| tools/lint/package.json | Updated @eslint/compat to newer version ^1.2.4 |
| tools/link/package.json | Removed unused @lg-tools/test from devDependencies |
| tools/eslint-plugin/package.json | Moved lodash to devDependencies and removed unused @lg-tools/test |
| tools/build/package.json | Updated glob from 10.3.12 to ^11.0.0 |
| packages/vertical-stepper/package.json | Moved @leafygreen-ui/button to devDependencies; removed @lg-tools/build and @lg-tools/storybook-utils (build tools available at root) |
| packages/toolbar/package.json | Removed unused @leafygreen-ui/hooks; moved test dependencies to devDependencies |
| packages/text-area/package.json | Removed unused @leafygreen-ui/icon and @leafygreen-ui/palette |
| packages/tabs/package.json | Moved @lg-tools/test-harnesses to devDependencies; added missing dev dependencies |
| packages/table/package.json | Reorganized dependencies, moving test/dev packages from dependencies to devDependencies |
| packages/split-button/package.json | Removed unused @leafygreen-ui/tokens |
| packages/side-nav/package.json | Added @floating-ui/react to devDependencies |
| packages/section-nav/package.json | Added @lg-tools/build to devDependencies |
| packages/search-input/package.json | Removed unused polished |
| packages/radio-box-group/package.json | Moved @leafygreen-ui/lib to devDependencies |
| packages/progress-bar/package.json | Moved polished from devDependencies to dependencies |
| packages/popover/package.json | Added typography and polished to devDependencies |
| packages/modal/package.json | Added development dependencies used in tests |
| packages/menu/package.json | Moved lodash and polished to devDependencies; removed unused @leafygreen-ui/text-input |
| packages/logo/package.json | Removed unused @leafygreen-ui/lib |
| packages/loading-indicator/package.json | Moved @lg-tools/test-harnesses to devDependencies |
| packages/input-option/package.json | Removed unused @leafygreen-ui/icon from devDependencies |
| packages/inline-definition/package.json | Removed unused @leafygreen-ui/tokens |
| packages/icon/package.json | Removed unused xml2json |
| packages/gallery-indicator/package.json | Moved @lg-tools/test-harnesses to devDependencies |
| packages/form-footer/package.json | Moved polished to devDependencies |
| packages/form-field/package.json | Added polished to devDependencies |
| packages/feature-walls/package.json | Removed unused @lg-tools/build |
| packages/drawer/package.json | Reorganized dependencies, moving unused/test packages appropriately |
| packages/descendants/package.json | Added polished and @floating-ui/react to devDependencies |
| packages/date-utils/package.json | Moved test utilities (lodash, timezone-mock) to devDependencies |
| packages/code/package.json | Reorganized dependencies, moving test tools to devDependencies |
| packages/code-editor/package.json | Moved test harnesses and prettier to devDependencies |
| packages/callout/package.json | Moved icon and code-related dev dependencies appropriately |
| packages/a11y/package.json | Removed unused @leafygreen-ui/lib |
| chat/message-feed/package.json | Moved message-related dependencies to devDependencies |
| chat/fixed-chat-window/package.json | Added dev dependencies for syntax highlighting and utilities |
| chat/chat-window/package.json | Reorganized dependencies for dev/test usage |
| chat/chat-layout/package.json | Moved test harnesses to devDependencies; added missing dev dependencies |
| charts/legend/package.json | Added dev dependencies for drag-and-drop and charting |
| pnpm-lock.yaml | Lock file updated to reflect all dependency changes |
| .changeset/five-bags-carry.md | Changeset documenting the cleanup for all affected packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Contributor
|
Size Change: +17.3 kB (+0.97%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
adamrasheed
force-pushed
the
ar/LG-5721
branch
from
bb8db5f to
633ef71
Compare
Contributor
|
Coverage after merging ar/LG-5721 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
* [LG-5666] MCP-UI App Scaffolding * Added component, sdk scaffolding, package json updates * cleanup * fixed linting * updated workspace * added tsconfig * updated build * r17 updates * updated turbo settings * added devDeps * rm sdk, changed directory structure, updated listdb styles * fix: r17 scripts (#3305) * update r17 scripts * filter apps from r17 build workflow * add mcpui to caches --------- Co-authored-by: Adam Thompson <[email protected]>
* [LG-2957] feat: GuideCue - Update Button Focus * comment cleanup * udpated changelog, udpated test assertion
* Update package.json * Create loading-spinner-types.md
* [LG-5748] chore: Add Text and Border Color Variants * updated changset
* feat: stricter post-build check on icon package * fix: not waiting for promises to finish
* feat: update CLI options for improved linking process * docs: add changelog * docs: apply review feedback * apply: review comments + docs update * apply: review comments (2)
* [LG-5748] fix: Fix Text and Border Color Variants * fixed colors * consoldiated changeset files
* refactor: share commands across lg and lg-build scripts * refactor: remove unused "direct" flag * refactor: minor changes * docs: changelog
* chore(message): remove compact variant mention in MessageActions spec * fix(input-bar): remove compact variant mention in props * chore(input-bar): changeset
…dd compact tooltip (#3329) * chore(chat-layout): add LG tooltip dep * feat(chat-layout): handle overflow in ChatSideNav and add compact tooltip * test(chat-layout): update stories * chore(chat-layout): changeset * feat(chat-layout): conditionally render tooltip if sidenav item text is truncated * chore(chat-layout): add LG hooks dep * fix(chat-layout): expand sidenav when descendant element is focused * chore(chat-layout): changesets * fix(chat-layout): increase chromatic snapshot delay
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore(split-button): export MenuItem and MenuItemProps * docs(split-button): README * chore(split-button): changeset
…and remove from docs (#3342) * fix(deprecated-packages): private deprecated package.json files * docs: rm deprecated packages from root README
* feat(input-bar): update disclaimer text * chore(input-bar): changeset
* fix: unhover issue * docs: add changeset * fix: force utc on sample series data * test: avoid race condition
* refactor(code-editor): use compact tooltip UI for IconButton instances * refactor(code): use compact tooltip UI for IconButton instance * chore: changesets * chore: update changesets
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: wait until series are added to the chart before next play step * Update charts/core/src/Chart.stories.tsx Co-authored-by: Copilot <[email protected]> * Update charts/core/src/BarChart.stories.tsx Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* feat: correctly merge array-fields (choose full override, no recursive) * docs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* [LG-5760] chore: FormFooter Sticky Styling * updated story * updates pt1 * updated story, style cleanup * cleanup, added changeset
…els (#3224) * updates chevron button labels * update select labels * update calendar cell label * Create date-picker-aria.md * Update DatePickerMenu.spec.tsx * Update DatePicker.testutils.tsx * Update date-picker-aria.md * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @TheSonOfThomp --------- Co-authored-by: Copilot <[email protected]>
* chore: update release pipeline * refactor: update publish script
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* scaffolds wizard package * Update pnpm-lock.yaml * scaffold WizardFooter * scaffold wizard step * [LG-5563] feat(Wizard) Adds Wizard (#3161) * initial Wizard component * Creates basic Wizard.tsx component Prompt: In the newly created package, create the Wizard component. Note: these docs mention `Wizard.Step` and `Wizard.Footer`. DO NOT create these yet. They will be created later The `@leafygreen-ui/wizard` is a general-purpose, multi-step page template, designed to create guided in-app flows and wizards: Based on the MultiStepWizard component in MMS, and intended to be used in the Product Deletion template. Feature Overview: - Takes in all Steps in the flow as children. - Renders the appropriate content for the current step - Internally handles step changing (with optional external control) Non-goals: - We will not be implementing this across MMS (MultiStepWizard is currently used in 26 files) - This will not support different url routes per step Wizard component The root flow component. Controls the rendering of the appropriate step based on a controlled prop, or uncontrolled internal state. Example ```tsx const [activeStep, setActiveStep] = useState(0) <Wizard activeStep={activeStep}> <Wizard.Step title="Step 1" description={<>Some description with a <Link>link</Link></>} > Some Content. Lorem ipsum dolor. </Wizard.Step> <Wizard.Step /> <Wizard.Step /> <Wizard.Footer backButtonProps={{ onClick: setActiveStep(x--) }} cancelButtonProps={{}} primaryButtonProps={{ onClick: setActiveStep(x++), variant: 'danger', disabled }} /> </Wizard> ``` Props: ```ts activeStep?: number; onStepChange?: (step: number) => void showStepper?: boolean; // omit for v1 ``` State: `[activeStep, setActiveStep] = useState<number> // if none provided as a prop` Events: - `onStepChange` : fired when the activeStep changes - this should still fire when controlled? Rendering: - Renders the appropriate Step based on the activeStep prop/state - Renders the Footer element, with enabled/hidden buttons based on the activeStep - If activeStep === 0, hides back button - Injects setActiveStep into Back and Primary buttons (if uncontrolled) * Creates WizardStep and WizardFooter Prompt: The Footer and Step components have been scaffolded. Create both components with the following spec: Step: A single Step in the multi-step flow. Must be rendered within a Wizard. ```ts title: ReactNode; description: ReactNode; children: ReactNode; ``` Footer: The footer element for the Wizard. A wrapper around LeafyGreen `FormFooter`, but allows us to optionally inject event handlers into the buttons. ``` backButtonProps: ButtonProps; cancelButtonProps: ButtonProps; primaryButtonProps: ButtonProps; ``` * footer& step stories * temp useWizardControlledValue * fix useWizardControlledValue * update Footer * Update package.json * use typography in Step * update descendants * update packages * the rest of the owl * update width * fix nits * Squashed commit of the following: commit c826033 Author: Adam Thompson <[email protected]> Date: Tue Sep 30 15:54:03 2025 -0400 Update isChildWithProperty.spec.tsx commit 01585d3 Merge: f3570c4 94745fb Author: Adam Thompson <[email protected]> Date: Tue Sep 30 13:28:59 2025 -0400 Merge branch 'main' into ac/cc-utils commit f3570c4 Author: Adam Thompson <[email protected]> Date: Tue Sep 30 13:28:37 2025 -0400 rm todo commit becf667 Author: Adam Thompson <[email protected]> Date: Fri Sep 26 16:50:05 2025 -0400 rm wizard commit f8463ac Author: Adam Thompson <[email protected]> Date: Fri Sep 26 16:50:00 2025 -0400 update index files commit 5e0d157 Author: Adam Thompson <[email protected]> Date: Fri Sep 26 16:49:50 2025 -0400 adds 2 level fragment test commit caf8a93 Author: Adam Thompson <[email protected]> Date: Fri Sep 26 16:39:09 2025 -0400 Update packages/lib/src/childQueries/findChildren/findChildren.ts Co-authored-by: Stephen Lee <[email protected]> commit ee977a1 Author: Adam Thompson <[email protected]> Date: Fri Sep 26 16:38:18 2025 -0400 Update packages/lib/src/childQueries/findChild/findChild.tsx Co-authored-by: Stephen Lee <[email protected]> commit ee32a26 Merge: ac2c485 366e851 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 15:20:23 2025 -0400 Merge branch 'main' into ac/cc-utils commit ac2c485 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 14:03:09 2025 -0400 Create lib-find-children.md commit 9cd7489 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 14:00:05 2025 -0400 Update findChildren.ts commit 90e8208 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:59:35 2025 -0400 Update findChildren.ts commit d7ae970 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:52:04 2025 -0400 update findChild/children with unwrapRootFragment commit a64ff9e Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:49:27 2025 -0400 Creates unwrapRootFragment commit 000f713 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:05:35 2025 -0400 Apply suggestions from code review `allChildren.length === 1` Co-authored-by: Copilot <[email protected]> commit c6d9c9d Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:00:30 2025 -0400 Update index.ts commit c369957 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 13:00:12 2025 -0400 mv child queries commit 5fe4f9d Author: Adam Thompson <[email protected]> Date: Thu Sep 25 12:59:35 2025 -0400 update index files commit c9261c8 Author: Adam Thompson <[email protected]> Date: Thu Sep 25 12:58:48 2025 -0400 mv componentQueries commit be05c4d Author: Adam Thompson <[email protected]> Date: Thu Sep 25 12:55:19 2025 -0400 Update findChildren.spec.tsx commit f493f6d Author: Adam Thompson <[email protected]> Date: Thu Sep 25 12:46:47 2025 -0400 update findChild tests commit 74f5f7e Author: Adam Thompson <[email protected]> Date: Thu Sep 25 12:46:28 2025 -0400 Fix isChildWithProperty tests commit 5439034 Author: Adam Thompson <[email protected]> Date: Wed Sep 24 19:05:18 2025 -0400 findChildren commit aa89584 Author: Adam Thompson <[email protected]> Date: Wed Sep 24 19:05:10 2025 -0400 Update findChild.tsx commit dda7ad5 Author: Adam Thompson <[email protected]> Date: Wed Sep 24 19:05:01 2025 -0400 isChildWithProperty commit ae3a41b Author: Adam Thompson <[email protected]> Date: Wed Sep 24 17:02:37 2025 -0400 mv existing utils * adds findChildren * adds TextNode * Update Wizard.spec.tsx * minor fixes * spread rest * adds wizard context assertions * fix exports * fix exports * Update TextNode.tsx * creates compound component * lint * update CompoundSubComponent api * update packages * add WizardProvider * update stories * Wizard * update findChild/ren * spread className * add "exceeded steps" warning * adds warning tests * chore(Wizard) Updates wizard utilities to use `hooks` and `compound-components` (#3200) * install cc * use CC in wiz * useControlled * rm isControlled check * lint * init wizard changeset * refactor(WizardFooter): simplify props by extending FormFooterProps * [LG-5562] feat(Wizard) Updates `Wizard` API (#3336) * rm step wrapper * rm descendants dep * export WizardProvider * delete-wizard-demo private endpoints useFetchRequiredActionTableData renam ReqAct cards composable basic table stream processing card federated db card applications card clusters card wizard step context Delete requiredActionsConfig.tsx re-enable wizard add useRequiredActionAcknowledgements mv required action. add skeleton Update ModelApiKeysCard.tsx * Update pnpm Update package.json * fix wizard changes * Adds `requiresAcknowledgement` prop to Wizard.Step * Implements `isAcknowledged` state inside provider * Update Wizard.stories.tsx * rm delete demo * Update wizard.md * rm temp changesets * Update README.md * Update WizardStep.spec.tsx * footer tests * Update Wizard.spec.tsx * update package json * update provider props * revert toast changes? * Update .npmrc * Update pnpm-lock.yaml * Update WizardStep.spec.tsx * exports form footer types * Update WizardFooter.types.ts * adds `totalSteps` to wizard context * fix bad merge * updates readme * updates tsdoc * fixes tests * fixes ack reset test * Update WizardStep.spec.tsx * fixes stories * [LG-5566] tests(Wizard) Implement TestUtils & LGIDs for `Wizard` (#3338) * rm step wrapper * rm descendants dep * export WizardProvider * delete-wizard-demo private endpoints useFetchRequiredActionTableData renam ReqAct cards composable basic table stream processing card federated db card applications card clusters card wizard step context Delete requiredActionsConfig.tsx re-enable wizard add useRequiredActionAcknowledgements mv required action. add skeleton Update ModelApiKeysCard.tsx * Update pnpm Update package.json * fix wizard changes * Adds `requiresAcknowledgement` prop to Wizard.Step * Implements `isAcknowledged` state inside provider * Update Wizard.stories.tsx * rm delete demo * Update wizard.md * rm temp changesets * Update README.md * Update WizardStep.spec.tsx * footer tests * Update Wizard.spec.tsx * update package json * update provider props * revert toast changes? * Update .npmrc * Update pnpm-lock.yaml * Update WizardStep.spec.tsx * exports form footer types * Update WizardFooter.types.ts * adds `totalSteps` to wizard context * fix bad merge * adds LGIDs * adds test utils * lint * fix bad merge * removes Step test utils * add layout comments * form-footer lgids * updates wizard testids * updates readme * updates tsdoc * fixes tests * fixes ack reset test * Squashed commit of the following: commit 4fd3668 Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:18:59 2025 -0500 fixes ack reset test commit 4f024b1 Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:11:35 2025 -0500 fixes tests commit f919ecc Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:11:29 2025 -0500 updates tsdoc commit 6842bbb Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:02:43 2025 -0500 updates readme * Update WizardStep.spec.tsx * Update WizardContext.tsx * Update WizardStep.spec.tsx * Squashed commit of the following: commit 982ef72 Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:52:15 2025 -0500 Update WizardStep.spec.tsx * fixes stories * Squashed commit of the following: commit 4b32ed6 Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 17:49:16 2025 -0500 fixes stories commit 982ef72 Author: Adam Michael Thompson <[email protected]> Date: Tue Nov 25 13:52:15 2025 -0500 Update WizardStep.spec.tsx * Update WizardStep.stories.tsx * Update packages/wizard/src/testing/getTestUtils.tsx Co-authored-by: Shaneeza <[email protected]> * Update README.md * use Button test utils * use test utils * Update pnpm-lock.yaml --------- Co-authored-by: Shaneeza <[email protected]> * Update packages/wizard/src/Wizard/Wizard.tsx Co-authored-by: Copilot <[email protected]> * Update packages/lib/src/childQueries/findChild/findChild.spec.tsx Co-authored-by: Copilot <[email protected]> * Update packages/lib/src/childQueries/findChildren/findChildren.spec.tsx Co-authored-by: Copilot <[email protected]> * Update packages/wizard/src/WizardStep/WizardStep.tsx Co-authored-by: Copilot <[email protected]> * Update getTestUtils.tsx --------- Co-authored-by: Shaneeza <[email protected]> Co-authored-by: Copilot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR addresses the warnings produced by the
pnpm validate. It is mostly removing unused packages, and moving certain packages todevDependanciesif they're only used for unit tests🎟 Jira ticket: https://jira.mongodb.org/browse/LG-5721
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes