-
Notifications
You must be signed in to change notification settings - Fork 260
feat(NODE-7328): Add ignoreUndefined option to EJSON serialization #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -574,6 +574,120 @@ describe('Extended JSON', function () { | |
| expect(result).to.deep.equal({ a: 1 }); | ||
| }); | ||
|
|
||
| describe('ignoreUndefined option', () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The changes you've made implicitly add support for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @baileympearson Added tests for |
||
| it('should convert undefined to null by default', () => { | ||
| const doc = { a: 1, b: undefined, c: 'test' }; | ||
| const serialized = EJSON.stringify(doc); | ||
| expect(serialized).to.equal('{"a":1,"b":null,"c":"test"}'); | ||
| }); | ||
|
|
||
| it('should omit undefined values when ignoreUndefined is true', () => { | ||
| const doc = { a: 1, b: undefined, c: 'test' }; | ||
| const serialized = EJSON.stringify(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.equal('{"a":1,"c":"test"}'); | ||
| }); | ||
|
|
||
| it('should handle nested undefined values with ignoreUndefined: true', () => { | ||
| const doc = { a: 1, nested: { b: undefined, c: 2 }, d: 'test' }; | ||
| const serialized = EJSON.stringify(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.equal('{"a":1,"nested":{"c":2},"d":"test"}'); | ||
| }); | ||
|
|
||
| it('should handle nested undefined values without ignoreUndefined (default behavior)', () => { | ||
| const doc = { a: 1, nested: { b: undefined, c: 2 }, d: 'test' }; | ||
| const serialized = EJSON.stringify(doc); | ||
| expect(serialized).to.equal('{"a":1,"nested":{"b":null,"c":2},"d":"test"}'); | ||
| }); | ||
|
|
||
| it('should handle undefined in arrays with ignoreUndefined: true', () => { | ||
| const doc = { arr: [1, undefined, 3] }; | ||
| const serialized = EJSON.stringify(doc, { ignoreUndefined: true }); | ||
| // JSON.stringify converts undefined array elements to null | ||
| expect(serialized).to.equal('{"arr":[1,null,3]}'); | ||
| }); | ||
|
|
||
| it('should handle undefined in arrays without ignoreUndefined (default behavior)', () => { | ||
| const doc = { arr: [1, undefined, 3] }; | ||
| const serialized = EJSON.stringify(doc); | ||
| expect(serialized).to.equal('{"arr":[1,null,3]}'); | ||
| }); | ||
|
|
||
| it('should handle object with all undefined values with ignoreUndefined: true', () => { | ||
| const doc = { a: undefined, b: undefined }; | ||
| const serialized = EJSON.stringify(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.equal('{}'); | ||
| }); | ||
|
|
||
| it('should work with other options like relaxed', () => { | ||
| const doc = { a: new Int32(10), b: undefined, c: new Double(3.14) }; | ||
| const serialized = EJSON.stringify(doc, { ignoreUndefined: true, relaxed: false }); | ||
| expect(serialized).to.equal('{"a":{"$numberInt":"10"},"c":{"$numberDouble":"3.14"}}'); | ||
| }); | ||
|
|
||
| it('should work with replacer function', () => { | ||
| const doc = { a: 1, b: undefined, c: 2 }; | ||
| const replacer = (key: string, value: unknown) => (key === 'a' ? 100 : value); | ||
| const serialized = EJSON.stringify(doc, replacer, 0, { ignoreUndefined: true }); | ||
| expect(serialized).to.equal('{"a":100,"c":2}'); | ||
| }); | ||
|
|
||
| it('should work with space parameter', () => { | ||
| const doc = { a: 1, b: undefined }; | ||
| const serialized = EJSON.stringify(doc, undefined, 2, { ignoreUndefined: true }); | ||
| expect(serialized).to.equal('{\n "a": 1\n}'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('ignoreUndefined option in EJSON.serialize', () => { | ||
| it('should convert undefined to null by default', () => { | ||
| const doc = { a: 1, b: undefined, c: 'test' }; | ||
| const serialized = EJSON.serialize(doc); | ||
| expect(serialized).to.deep.equal({ a: 1, b: null, c: 'test' }); | ||
| }); | ||
|
|
||
| it('should omit undefined values when ignoreUndefined is true', () => { | ||
| const doc = { a: 1, b: undefined, c: 'test' }; | ||
| const serialized = EJSON.serialize(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.deep.equal({ a: 1, c: 'test' }); | ||
| }); | ||
|
|
||
| it('should handle nested undefined values with ignoreUndefined: true', () => { | ||
| const doc = { a: 1, nested: { b: undefined, c: 2 }, d: 'test' }; | ||
| const serialized = EJSON.serialize(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.deep.equal({ a: 1, nested: { c: 2 }, d: 'test' }); | ||
| }); | ||
|
|
||
| it('should handle nested undefined values without ignoreUndefined (default behavior)', () => { | ||
| const doc = { a: 1, nested: { b: undefined, c: 2 }, d: 'test' }; | ||
| const serialized = EJSON.serialize(doc); | ||
| expect(serialized).to.deep.equal({ a: 1, nested: { b: null, c: 2 }, d: 'test' }); | ||
| }); | ||
|
|
||
| it('should handle undefined in arrays with ignoreUndefined: true', () => { | ||
| const doc = { arr: [1, undefined, 3] }; | ||
| const serialized = EJSON.serialize(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.deep.equal({ arr: [1, null, 3] }); | ||
| }); | ||
|
|
||
| it('should handle undefined in arrays without ignoreUndefined (default behavior)', () => { | ||
| const doc = { arr: [1, undefined, 3] }; | ||
| const serialized = EJSON.serialize(doc); | ||
| expect(serialized).to.deep.equal({ arr: [1, null, 3] }); | ||
| }); | ||
|
|
||
| it('should handle object with all undefined values with ignoreUndefined: true', () => { | ||
| const doc = { a: undefined, b: undefined }; | ||
| const serialized = EJSON.serialize(doc, { ignoreUndefined: true }); | ||
| expect(serialized).to.deep.equal({}); | ||
| }); | ||
|
|
||
| it('should work with relaxed: false option', () => { | ||
| const doc = { a: new Int32(10), b: undefined, c: new Double(3.14) }; | ||
| const serialized = EJSON.serialize(doc, { ignoreUndefined: true, relaxed: false }); | ||
| expect(serialized).to.deep.equal({ a: { $numberInt: '10' }, c: { $numberDouble: '3.14' } }); | ||
| }); | ||
| }); | ||
|
|
||
| it(`throws if Symbol.for('@@mdb.bson.version') is the wrong version in EJSON.stringify`, () => { | ||
| expect(() => | ||
| EJSON.stringify({ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option is only relevant to serialization, but EJSONOptions are shared for both serialization and deserialization.
What would you think about creating a separate interface for serialization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated the types. Caused a little more changes than I initially intended to but If it's fine with you I'm glad to help :)