chore(testing): prevent excessive MongoDB binary downloads in testing MONGOSH-1875 #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the testing infrastructure to prevent excessive MongoDB binary downloads by consolidating download locations and leveraging new locking mechanisms from the mongodb-runner package upgrade.
Key Changes:
- Upgraded
mongodb-runnerfrom v5.7.1 to v6.0.0 to utilize new locking mechanism - Consolidated MongoDB binary downloads to a single shared location (
tmpDir/mongodb-runner) - Applied code formatting changes (single quotes to double quotes throughout)
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testing/integration-testing-hooks.ts | Consolidated binary download location by setting shared binDir path and applying formatting updates |
| package.json | Upgraded mongodb-runner dependency to v6.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is making use of the new locking mechanism with the runner and downloader in mongodb-js/devtools-shared#580 as well as having a single place for all binaries.
gagik
force-pushed
the
gagik/excessive-download
branch
from
7908d1b to
8d69118
Compare
|
This looks promising! No |
gagik
force-pushed
the
gagik/excessive-download
branch
from
d38800e to
d282ce0
Compare
addaleax
reviewed
Oct 28, 2025
testing/integration-testing-hooks.ts
Outdated
| import which from "which"; | ||
| import { ConnectionString } from "mongodb-connection-string-url"; | ||
| import { MongoCluster, MongoClusterOptions } from "mongodb-runner"; | ||
| import { downloadCryptLibrary } from "../packages/build/src/packaging/download-crypt-library"; |
gagik
force-pushed
the
gagik/excessive-download
branch
from
88b53a8 to
48a7ec5
Compare
gagik
force-pushed
the
gagik/excessive-download
branch
from
728b582 to
2f7792c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is making use of the new locking mechanism with the runner and downloader in mongodb-js/devtools-shared#580.
It also sets 1 location for all binary downloads.
The relevant changes are in commit:
8d69118(#2559)