chore: refactor tsconfigs in packages to reuse "include", "exclude" and "outDir" #582
Conversation
| "bootstrap": "npm run compile", | ||
| "prepublishOnly": "npm run compile", | ||
| "compile": "tsc -p tsconfig.json && gen-esm-wrapper . ./.esm-wrapper.mjs && prettier --write .esm-wrapper.mjs", | ||
| "compile": "tsc -p tsconfig.json && gen-esm-wrapper . ./dist/.esm-wrapper.mjs", |
There was a problem hiding this comment.
Moving the esm-wrapper into the dist directory like every other package.
kraenhansen
force-pushed
the
kh/simpler-tsconfig
branch
from
4a6210d to
8ff1a78
Compare
kraenhansen
force-pushed
the
kh/simpler-tsconfig
branch
from
8ff1a78 to
e983925
Compare
| @@ -1,15 +1,9 @@ | |||
| { | |||
| "extends": "@mongodb-js/tsconfig-devtools/tsconfig.common.json", | |||
| "extends": "@mongodb-js/tsconfig-devtools/tsconfig.react.json", | |||
There was a problem hiding this comment.
There's no react in devtools-connect anymore, right? If you're referring to the "jsx": "react" bit below, I think you can just remove that at this point
There was a problem hiding this comment.
I was referring to the "jsx": "react" yes. Reverted this change and it still builds 👍
| "strict": true | ||
| }, | ||
| "include": ["src/**/*"], | ||
| "exclude": ["./src/types/*"], |
There was a problem hiding this comment.
^ This exclude isn't kept, right?
I'm a bit confused though, I don't think this worked previously as intended, with two keys of the same name in this file
There was a problem hiding this comment.
Yeah - it never worked 🙃 Just tested by reverting this change and tsc --listFiles. Also - even when in the exclude the package source files pull them in.
There was a problem hiding this comment.
yes I probably just messed up.
There was a problem hiding this comment.
Well, it all seems to work 🤷♀️ Basically just checking whether we should start to explicitly exclude these files now
kraenhansen
force-pushed
the
kh/simpler-tsconfig
branch
from
e983925 to
a7a314a
Compare
Description
I found many of the packages were repeating a lot for values that could be lifted to the common tsconfig using a new feature of the TypeScript compiler.
Merging this PR will:
${configDir}template variable introduced in TypeScript 5.5. Since these are settings which are normally overridden by the extending configuration, I don't expect these additions to cause any downstream breakage."allowJs": truefrom packages with no JS to discourage use of JS where TS could be used."strict": trueand"esModuleInterop": truein package tsconfigs, which are inherited from the common config."jsx": "react"settings to simply extend our react-specific config.download-urlpackage with the others, to output into./distinstead of./lib.Open Questions
Checklist