Skip to content

Conversation

addaleax
Copy link
Collaborator

This was previously missed before closing the ticket. Without this, dependencies that end up being bundled in node-runtime-worker-thread are not properly listed in the Compass SBOM.

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

…OSH-1856

This was previously missed before closing the ticket. Without this, dependencies
that end up being bundled in node-runtime-worker-thread are not properly
listed in the Compass SBOM.
@addaleax addaleax requested a review from a team as a code owner October 15, 2025 13:46
@addaleax addaleax requested review from Copilot and ivandevp October 15, 2025 13:46
@github-actions github-actions bot added the fix label Oct 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the SBOM (Software Bill of Materials) generation for Compass by including dependencies from the node-runtime-worker-thread package that were previously missing. The change ensures that bundled dependencies in this worker thread package are properly listed in the Compass SBOM.

Key Changes:

  • Added logic to copy and merge the node-runtime-worker-thread SBOM data into the main SBOM
  • Updated the SBOM generation pipeline to deduplicate entries after merging
  • Modified shell script quoting for better compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@addaleax addaleax added the no release notes Fix or feature not for release notes label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants