-
Notifications
You must be signed in to change notification settings - Fork 237
feat(databases-collections-list): replace the database and collection cards with tables COMPASS-9585 COMPASS-9586 #7399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
4e37ed6
export more leafygreen table components
lerouxb e952447
databases & collections tables
lerouxb 4907992
Merge branch 'main' into table-not-cards
lerouxb fa5add7
remove the item grid
lerouxb c20b2fd
name column changes
lerouxb ba9091a
port the inferred_from_privileges code to the new tables
lerouxb 2f953b2
port perf insights to the table
lerouxb 93eed90
outdated comment
lerouxb 9410a73
resize the columns
lerouxb a094b6b
more column fixes
lerouxb 35005a7
let's not add data size before speaking to someone
lerouxb 6ac88e6
Merge branch 'main' into table-not-cards
lerouxb 3f36c86
add delete button support
lerouxb e4360f3
add placeholders
lerouxb 363856e
size to fit
lerouxb 0e7e802
remove the databases/collections lists unit tests for now because vir…
lerouxb 9c015e0
Merge branch 'main' into table-not-cards
lerouxb d17f9ec
should be optional
lerouxb 71e8286
port the e2e tests
lerouxb 0d598de
Merge branch 'main' into table-not-cards
lerouxb 401e436
cleanup
lerouxb a28ec52
yay copilot
lerouxb 53767c3
will add these back in a second
lerouxb 833ef80
dummy tests to make CI happy for now
lerouxb f9ff633
scroll the workspace, not the table
lerouxb 14fb71a
more typesafe without casting
lerouxb 8549d4f
ignore some more
lerouxb d23b4ec
properties column to match indexes table until told otherwise
lerouxb 589d5be
debug the virtual scrolling
lerouxb 5eda9b0
fix the virtual scrolling e2e helper
lerouxb 1885ff9
actually just the table height
lerouxb 2fc1ce7
remove TODOs
lerouxb a722b41
turns out you need accessorKey for sorting to work
lerouxb f60913e
scroll some more just in case
lerouxb b262ba2
also sort by Properties
lerouxb 6945d1b
make it possible to opt out of virual rendering (for tests)
lerouxb ea9d0d1
don't use browser scrolling since we already scrolled using scrollToV…
lerouxb 050722f
don't screenshot. things aren't cards anymore anyway
lerouxb d10a156
database list unit tests
lerouxb 2918acc
add unit tests for collections
lerouxb a80bbc4
Merge branch 'main' into table-not-cards
lerouxb 6c8ecfe
more fixes for virtual scrolling
lerouxb 8f90b67
just pause for now
lerouxb 2879ab5
separate out the screenshots and debugging
lerouxb d6e76ca
do scroll 'past' the end
lerouxb 8d1127a
don't call them cards
lerouxb fdc9199
add test for the inferred from privileges tooltip in collections view
lerouxb 00325c3
test the view badge tooltip
lerouxb 1e35fe8
use the virtual table properly..
lerouxb c57427f
comment
lerouxb 8bf7b35
don't need that key because it is in a fragment
lerouxb 5a0c493
adding data-index ourselves shuts up the unit tests
lerouxb 4e2e041
oof
lerouxb 71a8740
disable virtual scrolling in e2e tests for now
lerouxb b405ad7
factor out ItemsTable and use the correct hook for virtual vs normal
lerouxb d730e79
todo ticket
lerouxb 4590dd9
bring back the databases-collections plugin tests
lerouxb cb1c770
undo depcheck changes
lerouxb 50d4a98
better env var name
lerouxb e294fc2
remove redundant type constituent comments
lerouxb ded586b
don't set data-index
lerouxb 074b846
meant to use that as a component
lerouxb 70d9b32
generic
lerouxb 977c598
Merge branch 'main' into table-not-cards
lerouxb c61ade4
also disable virtual rendering in web tests
lerouxb a337de6
Update packages/databases-collections-list/src/items-table.tsx
lerouxb a75e6e9
looser generic types
lerouxb f002242
don't remove readonly badges
lerouxb b8f9c33
clicking on a tr is flaky
lerouxb 8ed3962
align the bottom of the element to the bottom of the view so it does …
lerouxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually added this specifically so that mocha gets the best chance of cleaning up via global hooks instead of leaving zombie processes that are hard to find and kill 😆 Don't mind that change, just thought I'd provide the context for why this is waiting here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to have the opposite effect 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, cleans up for me just fine, weird 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reproduce:
Then once the tests start running press ctrl-c. It helps if you have a test that's going to fail by retrying forever and eventually timing out, though.