feat(audio): save recordings as Ogg Opus - #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mic.oggandsystem.ogg).oggpathsWhy
WAV writes previously happened synchronously on the audio callback and recordings depended on a clean session stop. Ogg page boundaries let completed audio remain independently recoverable when a session or process terminates unexpectedly, while Opus substantially reduces recording size.
Impact
New sessions store separate microphone and system recordings as Ogg/Opus. A clean stop drains the bounded queue and writes EOS; an abnormal stop leaves the already completed pages readable without requiring a post-processing concatenation step.
Validation
swift buildcargo fmt --all -- --checkcargo test -p wisp-core -p wisp-storage -p wisp-audiokit(23 tests)afinfo