refactor: address rust-code-reviewer findings - #19
Merged
Conversation
Unify SourceLabel through wisp-core, tighten FFI source mapping, and clean up storage/desktop ergonomics surfaced by the review loop. Co-authored-by: Cursor <cursoragent@cursor.com>
GitHub Actions failed before cargo fmt/clippy because the locked flake-utils tarball returned HTTP 404. Inline eachDefaultSystem instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Run rustc/cargo via `nix develop .#ci` so cache keys match the Nix toolchain. macOS workflow uses the same ci devShell for consistency. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace magic-nix-cache with flakehub-cache-action and grant id-token: write so GitHub OIDC can authenticate to FlakeHub Cache. Co-authored-by: Cursor <cursoragent@cursor.com>
Linux CI builds wisp-desktop via GPUI; audiokit only exported macOS-gated types. Stub the public API so the workspace compiles everywhere. Co-authored-by: Cursor <cursoragent@cursor.com>
GPUI links against X11 libraries unavailable in the ci devShell. The app targets macOS only; check it on macos runners instead. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceLabelby re-exportingwisp_core::SourceLabelfromwisp-audiokit, removing the duplicate enumMIC/SYSTEMexplicitly and discard unknown source values instead of defaulting toSystemSessionId,SegmentId) with private inner fields andFrom<i64>row_to_segmentno longer uses double-Result;Sessions::listusescollect)VecDequelog ring buffer,Debugimpls,FromStrforSourceLabel, remove redundantformat_errTest plan
cargo clippy --workspace --all-targetscargo test --workspace(30 tests)Made with Cursor