Complete macOS audio backend migration - #112
Merged
Merged
Conversation
pranc1ngpegasus
force-pushed
the
agent/macos-backend-migration
branch
from
August 1, 2026 10:22
914c001 to
dabd46f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionOrchestratorwith productionMacosCaptureBackendandMacosTranscriberBackendimplementations.TranscriberBackend::push, while keeping Ogg recording on the capture side.Why
PR #108 introduced the cross-platform capture/transcription abstractions, but macOS production code still had paths that bypassed the orchestrator. This completes that migration so macOS uses the abstraction end to end before Windows/Linux backends are added.
Base
maindirectly.Impact
Validation
cargo test --workspace --exclude wisp-desktop --no-fail-fastcargo clippy --workspace --exclude wisp-desktop --all-targets -- -D warningscargo test -p wisp-desktop --features gpui/runtime_shaders session_runner::tests(2 passed)nix shell nixpkgs#cargo-xwin --command env RUSTC_BOOTSTRAP=1 cargo xwin clippy -Z build-std=std,panic_abort -p wisp-audiokit --target x86_64-pc-windows-msvc --tests -- -D warningsswift build --package-path native/WispAudioKitbash formal/check.sh(Kani 5/5, Shuttle 2/2)cargo fmt --all -- --checkgit diff --checkEnvironment-only gaps
metal; the runtime-shader test path compiled and exercised the affected session runner.