Add microphone mute control - #101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Users need to temporarily exclude their microphone from a recording without stopping the session or interrupting system-audio capture and transcription.
Impact
During an active recording, users can mute and unmute the microphone. Muted intervals remain as silence in
mic.ogg, preserving synchronization withsystem.ogg; microphone speech from those intervals is not transcribed.Validation
cargo test -p wisp-audiokit --all-targetscargo clippy -p wisp-audiokit --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkswift build --scratch-path /tmp/wisp-audiokit-mute-buildcargo check --workspace --all-targetsreached the desktop GPUI dependency but could not complete because this machine does not have the Metal compiler (xcrun: unable to find utility "metal").swift testis also unavailable in the installed Command Line Tools because the XCTest module is missing; the Swift package itself builds successfully.