Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This pull request aligns audit configurations across multiple services by introducing a centralized configuration override and updating application versioning in Helm charts and image tags. Key changes include the addition of a new "configOverride" block in values-mojaloop-iso20022.yaml, the inclusion of Kafka topic definitions in values-backend.yaml, and synchronized version bumps across Helm chart and values files.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| local-deployment-methods/helmfile/values-mojaloop-iso20022.yaml | Added centralized audit and Kafka logging configuration via configOverride |
| local-deployment-methods/helmfile/values-backend.yaml | Introduced Kafka topic definitions for audit, log, and trace events |
| account-lookup-service/, ml-api-adapter/, bulk-api-adapter/* | Updated appVersion and image tag values to align with the audit changes |
Comments suppressed due to low confidence (1)
local-deployment-methods/helmfile/values-mojaloop-iso20022.yaml:33
- YAML keys containing periods (e.g. client.id) can be misinterpreted by some parsers; consider quoting these keys (e.g. "client.id") to ensure consistent parsing.
client.id: producer-event-audit
kalinkrustev
left a comment
There was a problem hiding this comment.
Looks good, still needs a code owner review



No description provided.